Add BidstreamClient and SharingClient, deprecate UID2Client #63
Conversation
| @@ -44,4 +44,8 @@ public enum DecryptionStatus { | |||
| * to decrypt a UID2 token. Ensure the factory class matches the token type you are decrypting. | |||
| */ | |||
| INVALID_IDENTITY_SCOPE, | |||
| /** | |||
| * INVALID_TOKEN_LIFETIME: If token generated timestamp is longer than allow_clock_skew_seconds | |||
There was a problem hiding this comment.
this comment is not correct, this error should occur when the token's lifetime is greater than is allowed
There was a problem hiding this comment.
It's not correct to say "longer than allow_clock_skew_seconds"; that doesn't cause this error.
We can write here: Token has invalid timestamps.
There was a problem hiding this comment.
My bad, that makes sense.
| @@ -104,7 +92,12 @@ public void crossPlatformConsistencyCheck_Decrypt() throws Exception { | |||
| assertEquals(EXAMPLE_UID, res.getUid()); | |||
| } | |||
|
|
|||
| private static void validateAdvertisingToken(String advertisingTokenString, IdentityScope identityScope, IdentityType identityType) { | |||
| public static void validateAdvertisingToken(String advertisingTokenString, IdentityScope identityScope, IdentityType identityType, int tokenVersion) { | |||
| if (tokenVersion == 2) { | |||
There was a problem hiding this comment.
can we use an enum for token versions?
There was a problem hiding this comment.
I created a new class called TokenVersionForTesting for the token version
There was a problem hiding this comment.
hmm ok why do we do it differently than C# ?
There was a problem hiding this comment.
I feel they are the same. in the C#, "TokenVersion" class is also only used for testing. here
| assertTrue(response.isSuccess()); | ||
| assertEquals(EXAMPLE_UID, response.getUid()); | ||
| assertEquals(tokenVersion.ordinal() + 2, response.getAdvertisingTokenVersion()); | ||
| assertEquals(tokenVersion.ordinal() + 2, response.getAdvertisingTokenVersion()); |
There was a problem hiding this comment.
My bad, will remove one.
caroline-ttd
deleted the
ccm-UID2-2878-dsp-refactor-and-check-token-lifetimes
branch
Introduce two new clients BidStreamClient and SharingClient and deprecate the existing UID2Client.