Add timeout and metrics on delta chunk sends. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a metric for how long this operation takes so we can reduce the timeout once we have more data.
lionell-pack-ttd
commented
Feb 1, 2024
| @@ -85,6 +94,8 @@ public Future<Void> send(OptOutEntry entry) { | |||
| } | |||
|
|
|||
| if (SUCCESS_STATUS_CODES.contains(resp.statusCode())) { | |||
| long finishTimeMs = System.currentTimeMillis(); | |||
| timer.record(finishTimeMs - startTimeMs, TimeUnit.MILLISECONDS); | |||
There was a problem hiding this comment.
Currently only recording successful sends - failures could happen for a range of reasons that might affect the time they take, so having a timer on "any failed request" probably isn't useful.
lionell-pack-ttd
commented
Feb 1, 2024
| @@ -42,7 +48,8 @@ public Future<Void> send(BiFunction<URI, HttpMethod, HttpRequest> requestCreator | |||
| Promise<Void> promise = Promise.promise(); | |||
|
|
|||
| HttpRequest request = requestCreator.apply(this.uri, this.method); | |||
| CompletableFuture<HttpResponse<String>> asyncResponse = this.httpClient.sendAsync(request, HttpResponse.BodyHandlers.ofString()); | |||
| CompletableFuture<HttpResponse<String>> asyncResponse = this.httpClient.sendAsync(request, HttpResponse.BodyHandlers.ofString()) | |||
| .orTimeout(this.resultTimeoutMs, TimeUnit.MILLISECONDS); | |||
There was a problem hiding this comment.
The timeout. This won't hit the retry logic - the retries only kick in if the overall network request succeeds and the server returns a failure (i.e. the future succeeds with a response indicating failure). This is consistent with that behavior, but maybe we want to think about whether exceptions should also trigger the retry logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes UID2-2612.
Add timeout to delta chunk send operation.
Add a metric for how long this operation takes so we can reduce the timeout once we have more data.