Skip to content

Commit

Permalink
Apply suggestions from code review by @phackstock
Browse files Browse the repository at this point in the history
Co-authored-by: Philip Hackstock <[email protected]>
  • Loading branch information
danielhuppmann and phackstock authored Mar 21, 2024
1 parent 8bb7086 commit 3771382
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions pyam/iiasa.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ class Connection(object):
Notes
-----
Credentials (username & password) are not required to access any public |ixmp4|
or Scenario Explorer database (i.e., with Guest login).
Credentials (username & password) are not required to access public |ixmp4|
or Scenario Explorer databases (i.e., with Guest login).
"""

def __init__(self, name=None, creds=None, auth_url=_AUTH_URL):
Expand Down Expand Up @@ -674,7 +674,7 @@ def lazy_read_iiasa(
Credentials (username & password) are not required to access any public |ixmp4|
or Scenario Explorer database (i.e., with Guest login).
"""
if name in [i.name for i in ixmp4.conf.settings.manager.list_platforms()]:
if name in [platform.name for platform in ixmp4.conf.settings.manager.list_platforms()]:
raise NotImplementedError(
"The function `lazy_read_iiasa()` does not support ixmp4 platforms."
)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_ixmp4.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def test_ixmp4_filters(test_platform, test_df_year, filters):
# test writing to platform
test_df_year.to_ixmp4(platform=test_platform)

# add 'version' meta indicator (indicator during imp4 roundtrip)
# add 'version' meta indicator (indicator during ixmp4 roundtrip)
test_df_year.set_meta(1, "version")

# read with filters
Expand Down

0 comments on commit 3771382

Please sign in to comment.