Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set explicit minimum numpy version (1.19.0) #556

Merged
merged 5 commits into from
Jul 1, 2021

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Jun 30, 2021

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR adds an explicit minimum dependency version for numpy (and also adds it to the dependency-tests workflow).

closes #555

@danielhuppmann danielhuppmann added the dependencies Pull requests that update a dependency file label Jun 30, 2021
@danielhuppmann danielhuppmann self-assigned this Jun 30, 2021
@danielhuppmann
Copy link
Member Author

fyi @EmiFej

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #556 (88cf87b) into main (e008f62) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #556   +/-   ##
=====================================
  Coverage   93.6%   93.6%           
=====================================
  Files         48      48           
  Lines       5242    5242           
=====================================
  Hits        4909    4909           
  Misses       333     333           
Impacted Files Coverage Δ
setup.py 0.0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e008f62...88cf87b. Read the comment docs.

@danielhuppmann danielhuppmann merged commit 6de47cc into IAMconsortium:main Jul 1, 2021
@danielhuppmann danielhuppmann deleted the devops/numpy branch July 1, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old numpy version causes issues in filter()
1 participant