Update expected figures to use matplotlib 3.5 #590
Conversation
Codecov Report
@@ Coverage Diff @@
## main #590 +/- ##
=====================================
Coverage 94.2% 94.2%
=====================================
Files 50 50
Lines 5331 5331
=====================================
Hits 5022 5022
Misses 309 309
Continue to review full report at Codecov.
|
| @@ -437,7 +437,7 @@ def stack( | |||
|
|
|||
| def as_series(index, name): | |||
| _idx = [i[0] for i in index] | |||
| return pd.Series([0] * len(index), index=_idx, name=name) | |||
| return pd.Series([0] * len(index), index=_idx, name=name, dtype="int") | |||
There was a problem hiding this comment.
Not clear why this is needed, can you let me know why?
Can this be sent through calling code? e.g., either with
- move this
dtypeup as a kwarg or - add generic
**kwargswhich then passes through to this series call
There was a problem hiding this comment.
This is a function only used within this function (see just the following line) to select the rows where a timeseries crosses zero. Adding the dtype explicitly is done just to silence a warning in the log.
There was a problem hiding this comment.
Gotcha - won't hold up. But I assume this will not work for non-integer times?
There was a problem hiding this comment.
facepalm reread, and realize no issue here. sorry!
Please confirm that this PR has done the following:
Documentation AddedName of contributors Added to AUTHORS.rstDescription of PR
Alerted by the nightly tests... It seems that matplotlib v3.5 changed the order of the legends in stackplot-figures with totals. This PR simply updates the test-figures to reflect the new behavior (alternative approach: change the way that the "total" is added to the legend).
In addition, the PR silences a warning in the plotting module and changes the readme and install-bat-file from
py.testtopytest(because this seems to be the more common usage).