Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert_iamframe_equals() passes if all-nan-cols are present #608

Merged

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Jan 21, 2022

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

Currently, assert_iamframe_equal() fails if one of the IamDataFrames has a meta-column of all-nan's (and the column doesn't exist in the other IamDataFrame). Arguably, all-nan should be treated as identical to "column doesn't exist".

The PR also adds a page for the testing module to the docs.

Closes #515

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #608 (005434b) into main (28089d3) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #608   +/-   ##
=====================================
  Coverage   94.3%   94.3%           
=====================================
  Files         53      54    +1     
  Lines       5471    5477    +6     
=====================================
+ Hits        5162    5168    +6     
  Misses       309     309           
Impacted Files Coverage Δ
pyam/testing.py 75.0% <100.0%> (ø)
tests/test_testing.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28089d3...005434b. Read the comment docs.

@danielhuppmann danielhuppmann marked this pull request as ready for review January 21, 2022 09:10
Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Just one small comment and it seems there some conflict in the README that needs to be resolved.

pyam/testing.py Outdated Show resolved Hide resolved
@phackstock
Copy link
Contributor

Perfect, good to merge from my side.

@danielhuppmann danielhuppmann merged commit c62ee8c into IAMconsortium:main Jan 24, 2022
@danielhuppmann danielhuppmann deleted the compare/meta-nan-cols branch January 24, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assert_iamframe_equal() fails on meta-columns with all-nan values
2 participants