-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert_iamframe_equals()
passes if all-nan-cols are present
#608
assert_iamframe_equals()
passes if all-nan-cols are present
#608
Conversation
Codecov Report
@@ Coverage Diff @@
## main #608 +/- ##
=====================================
Coverage 94.3% 94.3%
=====================================
Files 53 54 +1
Lines 5471 5477 +6
=====================================
+ Hits 5162 5168 +6
Misses 309 309
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Just one small comment and it seems there some conflict in the README that needs to be resolved.
Perfect, good to merge from my side. |
Please confirm that this PR has done the following:
Name of contributors Added to AUTHORS.rstDescription of PR
Currently,
assert_iamframe_equal()
fails if one of the IamDataFrames has a meta-column of all-nan's (and the column doesn't exist in the other IamDataFrame). Arguably, all-nan should be treated as identical to "column doesn't exist".The PR also adds a page for the testing module to the docs.
Closes #515