-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add offset method to compute offsets relative to base-year values #659
Conversation
Codecov Report
@@ Coverage Diff @@
## main #659 +/- ##
=====================================
Coverage 94.5% 94.6%
=====================================
Files 59 59
Lines 5742 5765 +23
=====================================
+ Hits 5431 5454 +23
Misses 311 311
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not against including such a function, but it is also quite specific. Unsure, whether discoverability will become an issue at some point or already is.
Co-authored-by: Jonas Hörsch <[email protected]>
Hi both - have updated based on your suggestions. Should be ready. |
LGTM |
Given positive response here, will go ahead with merge. See #662 for an issue on expanding documentation further. |
Please confirm that this PR has done the following:
Description of PR
This PR introduces an
offset()
method which allows a user to compute offsets relative to base-time-periods in the same style asnormalize()
.