-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Df load meta #679
Df load meta #679
Conversation
Codecov Report
@@ Coverage Diff @@
## main #679 +/- ##
=======================================
- Coverage 94.7% 94.7% -0.1%
=======================================
Files 59 59
Lines 5800 5812 +12
=======================================
+ Hits 5495 5506 +11
- Misses 305 306 +1
Continue to review full report at Codecov.
|
Thanks @gidden! One side effect of your clean-up is that the warnings are no longer shown if the (timeseries) |
Changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gidden, lgtm!
@danielhuppmann - only style changes, should be g2g |
With lgtm above and passing tests, merging |
Please confirm that this PR has done the following:
[ ] Tests Added- existing tests cover use caseAdding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)
Please add a single line in the release notes similar to the following:
Description of PR
This PR implements support for setting metadata by dataframes, and implements all metadata setting solely via
set_meta()