Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Df load meta #679

Merged
merged 8 commits into from
Jul 10, 2022
Merged

Df load meta #679

merged 8 commits into from
Jul 10, 2022

Conversation

gidden
Copy link
Member

@gidden gidden commented Jun 30, 2022

Please confirm that this PR has done the following:

  • [ ] Tests Added - existing tests cover use case
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

Description of PR

This PR implements support for setting metadata by dataframes, and implements all metadata setting solely via set_meta()

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #679 (776494b) into main (74979e7) will decrease coverage by 0.0%.
The diff coverage is 85.7%.

@@           Coverage Diff           @@
##            main    #679     +/-   ##
=======================================
- Coverage   94.7%   94.7%   -0.1%     
=======================================
  Files         59      59             
  Lines       5800    5812     +12     
=======================================
+ Hits        5495    5506     +11     
- Misses       305     306      +1     
Impacted Files Coverage Δ
pyam/core.py 94.6% <85.7%> (-0.1%) ⬇️
pyam/iiasa.py 85.8% <0.0%> (ø)
pyam/aggregation.py 99.1% <0.0%> (+<0.1%) ⬆️
tests/test_feature_aggregate.py 98.9% <0.0%> (+<0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74979e7...776494b. Read the comment docs.

@danielhuppmann
Copy link
Member

Thanks @gidden! One side effect of your clean-up is that the warnings are no longer shown if the (timeseries) data sheet and the meta of a file are inconsistent. Given that we are starting to use the meta-indicators-feature that more in the scenario-submission workflows, I'd be very much in favor of keeping the warnings.

@gidden
Copy link
Member Author

gidden commented Jul 1, 2022

Changes to load_meta() reverted!

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gidden, lgtm!

@gidden
Copy link
Member Author

gidden commented Jul 8, 2022

@danielhuppmann - only style changes, should be g2g

@gidden
Copy link
Member Author

gidden commented Jul 10, 2022

With lgtm above and passing tests, merging

@gidden gidden merged commit b7a89b6 into IAMconsortium:main Jul 10, 2022
@gidden gidden deleted the df_load_meta branch July 10, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants