Use new IIASA-manager API with token refresh #684
Conversation
|
The equivalent to the anonymous login would be logging in as the "guest" user. |
Codecov Report
@@ Coverage Diff @@
## main #684 +/- ##
=======================================
- Coverage 94.7% 94.7% -0.1%
=======================================
Files 59 59
Lines 5807 5836 +29
=======================================
+ Hits 5504 5529 +25
- Misses 303 307 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Ok, not sure if the "guest" user should have a password... Let's discuss next week. |
| def obtain_jwt(self): | ||
| r = self.client.post("/v1/token/obtain/", json=self.creds) | ||
| if r.status_code == 401: | ||
| raise ValueError( |
There was a problem hiding this comment.
If a (non-expert) user reads the error message and tries to put the auth-url into his/her browser, this returns an unhelpful "Not Found" page - so I would rather use a url that users can "use".
pyam/iiasa.py
Outdated
| r = requests.get(url, headers=self._headers) | ||
| # TODO: application-list will be reimplemented in conjunction with ixmp-server | ||
| url = "/".join([self._auth_url, "legacy", "applications"]) | ||
| r = requests.get(url, headers=self.auth()) |
There was a problem hiding this comment.
I would use httpx here as well. You can pass the auth object when instantiating the client and it will be called for every request.
There was a problem hiding this comment.
Thanks, implemented!
Please confirm that this PR has done the following:
Documentation AddedName of contributors Added to AUTHORS.rstDescription of PR
This PR refactors the IIASA-manager-API authentication to the new (short-lived) token, including automated refresh. The PR also stricter behavior when reading a config file fails, and adds explicit test if arguments are missing from the credentials.
We decided to leave the current legacy-implementation for the anonymous login and application-list, because these features will change with the new ixmp package.