Remove ixmp as optional dependency #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #688 +/- ##
=======================================
+ Coverage 94.7% 94.8% +0.1%
=======================================
Files 59 58 -1
Lines 5836 5814 -22
=======================================
- Hits 5529 5517 -12
+ Misses 307 297 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Will merge in one week (August 26) if I do not hear any objections... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Description of PR
This PR removes the ixmp packages as an optional dependency. The feature to read IAMC-style scenario data directly from an ixmp database instance was untested, does not support meta-indicators and, as far as I know, is not used by anyone.
The feature to query data from an IIASA Scenario Explorer database (
pyam.read_iiasa()) is not affected by this PR!The PR prepares for the release of ixmp 4.0.0, based on a discussion with @meksor and @phackstock today.
@gidden @OFR-IIASA @behnam-zakeri @byersiiasa, please shout if you are using this feature or know of anyone who does...