Refactor initialization for simpler maintenance #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coroa
force-pushed
the
split-format-data
branch
from
145ee39
to
c841dcb
Compare
Codecov Report
@@ Coverage Diff @@
## main #730 +/- ##
=====================================
Coverage 95.0% 95.0%
=====================================
Files 59 59
Lines 6014 6020 +6
=====================================
+ Hits 5717 5725 +8
+ Misses 297 295 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Feb 22, 2023
Co-authored-by: Matthew Gidden <[email protected]>
Co-authored-by: Matthew Gidden <[email protected]>
Co-authored-by: Matthew Gidden <[email protected]>
coroa
force-pushed
the
split-format-data
branch
from
c841dcb
to
3146714
Compare
|
This LGTM but best if @danielhuppmann approves! |
danielhuppmann
approved these changes
Feb 23, 2023
| df = df.stack(dropna=True) | ||
| df.name = "value" | ||
| df.index.names = df.index.names[:-1] + [time_col] | ||
| df, time_col, extra_cols = _format_data_to_series(df, index) | ||
|
|
||
| # cast value column to numeric |
There was a problem hiding this comment.
Might also put these two checks into their own function _check_data_integrity()...
Co-authored-by: Daniel Huppmann <[email protected]>
gidden
reviewed
Feb 24, 2023
|
LGTM - thanks @coroa ! Will merge after tests pass. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Documentation AddedName of contributors Added to AUTHORS.rstDescription of PR
On-top of #729.Rebased tomain.Splits
utils.format_datainto 6 different functions:_convert_r_columns(df)- Check and convert R-style year columns_knead_data(df, **kwargs)- Replace, rename and concat according to user arguments_format_from_database(df)- Post-process database results_intuit_column_groups(df, index)- Check and categorise columns in dataframe_format_data_to_series(df, index)- Convert a long or wide pandas dataframe to a series with the required columns_validate_complete_index(df)Functionally it should be neutral. Make sure to look at individual commits to follow the refactoring trail.