Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set name of series returned by aggregate_time() #790

Merged

Conversation

danielhuppmann
Copy link
Member

Description of PR

Quickfix for #785.

FYI @adrivinca

@danielhuppmann danielhuppmann self-assigned this Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #790 (7052f67) into main (fa3fed0) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #790   +/-   ##
=====================================
  Coverage   94.7%   94.7%           
=====================================
  Files         62      62           
  Lines       5965    5966    +1     
=====================================
+ Hits        5650    5651    +1     
  Misses       315     315           
Files Coverage Δ
pyam/aggregation.py 99.1% <100.0%> (+<0.1%) ⬆️

@danielhuppmann danielhuppmann merged commit f023ec3 into IAMconsortium:main Oct 16, 2023
11 checks passed
@danielhuppmann danielhuppmann deleted the quickfix/aggregate-time branch October 17, 2023 17:23
@adrivinca
Copy link

adrivinca commented Oct 18, 2023

Thanks for the fix. I am not completely clear on what changed in the new version and caused the error. However the remaining questions are:

  • why is this issue not tested? should you add test to avoid similar errors happen in the future?
  • does this occurs with the other _aggregate* functions? they need to be tested otherwise the package is not stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants