Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add December 2017 DAC codelist update to changelog #312

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Add December 2017 DAC codelist update to changelog #312

merged 2 commits into from
Apr 26, 2019

Conversation

andylolz
Copy link
Contributor

@andylolz
Copy link
Contributor Author

andylolz commented Dec 6, 2018

Any reason this was never merged? It doesn’t look like a changelog entry was ever added corresponding to these changes.

@andylolz andylolz changed the title December 2017 DAC codelist update Add December 2017 DAC codelist update to changelog Jan 29, 2019
@andylolz andylolz mentioned this pull request Feb 13, 2019
Merged
@andylolz
Copy link
Contributor Author

I’ve fixed the merge conflict on this PR, just in case anyone fancies reviewing and/or merging it.

@samuele-mattiuzzo
Copy link
Contributor

Hey @andylolz will ping the BAs to look at this, been quite the hectic period recently so might have slipped through the cracks!

@amy-silcock @PetyaKangalova @JoshStanleyDevInit can one of you take a quick look at this before it falls behind? ❤️

PetyaKangalova
PetyaKangalova approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@PetyaKangalova PetyaKangalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct so approving. Linking to pull request as well: https://github.com/IATI/IATI-Codelists-NonEmbedded/pull/231/files

@PetyaKangalova PetyaKangalova merged commit d1f1f9c into IATI:master Apr 26, 2019
@andylolz andylolz deleted the dec-2017-dac branch April 26, 2019 09:50
@andylolz
Copy link
Contributor Author

been quite the hectic period recently so might have slipped through the cracks!

Kk so, here’s the list of all open PRs to public IATI repos:
https://github.com/pulls?q=is%3Aopen+is%3Apr+user%3Aiati

This is a really helpful view that github provides. It should make it easy to track PRs. I don’t mind about this one at all, but I wouldn’t want you to miss something important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetyaKangalova PetyaKangalova PetyaKangalova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andylolz @samuele-mattiuzzo @PetyaKangalova