Removal of hard coded library name in Assembler.groovy #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Behm <[email protected]>
drbruce-git
approved these changes
Aug 16, 2022
drbruce-git
added a commit
that referenced
this pull request
Oct 17, 2022
* Fix NPE when using dependency file (#230) * move logical file creation after call to copySourceFiles Signed-off-by: Luke Burgess <[email protected]> * setting logical file in copySourceFiles Signed-off-by: Luke Burgess <[email protected]> * adding check for dependency resolver Signed-off-by: Luke Burgess <[email protected]> Co-authored-by: Luke Burgess <[email protected]> * Assembler.groovy removal of hard coded library name (#237) Signed-off-by: Dennis Behm <[email protected]> * Skip unnecessary impact calculation on created full build list (#236) * skip unnecessary impact calculation on generated full build list Signed-off-by: Dennis Behm <[email protected]> * Revised implementation of reporting of external impacts feature (#239) * Revised implementation of reporting of external impacts Signed-off-by: Dennis Behm <[email protected]> * Revisions to Function Overview of Report External Impacts Signed-off-by: Lauren Li <[email protected]> * Handle case with back-level DBB server Signed-off-by: Dennis Behm <[email protected]> Signed-off-by: Dennis Behm <[email protected]> Signed-off-by: Lauren Li <[email protected]> Co-authored-by: Lauren Li <[email protected]> Signed-off-by: Dennis Behm <[email protected]> Signed-off-by: Lauren Li <[email protected]> Co-authored-by: Luke Burgess <[email protected]> Co-authored-by: Luke Burgess <[email protected]> Co-authored-by: Dennis Behm <[email protected]> Co-authored-by: Lauren Li <[email protected]>
drbruce-git
added a commit
that referenced
this pull request
Oct 17, 2022
* Fix NPE when using dependency file (#230) (#231) * move logical file creation after call to copySourceFiles Signed-off-by: Luke Burgess <[email protected]> * setting logical file in copySourceFiles Signed-off-by: Luke Burgess <[email protected]> * adding check for dependency resolver Signed-off-by: Luke Burgess <[email protected]> Co-authored-by: Luke Burgess <[email protected]> Co-authored-by: Luke Burgess <[email protected]> Co-authored-by: Luke Burgess <[email protected]> * Merge Develop into main for zAppBuild v2.5.2 release (#252) * Fix NPE when using dependency file (#230) * move logical file creation after call to copySourceFiles Signed-off-by: Luke Burgess <[email protected]> * setting logical file in copySourceFiles Signed-off-by: Luke Burgess <[email protected]> * adding check for dependency resolver Signed-off-by: Luke Burgess <[email protected]> Co-authored-by: Luke Burgess <[email protected]> * Assembler.groovy removal of hard coded library name (#237) Signed-off-by: Dennis Behm <[email protected]> * Skip unnecessary impact calculation on created full build list (#236) * skip unnecessary impact calculation on generated full build list Signed-off-by: Dennis Behm <[email protected]> * Revised implementation of reporting of external impacts feature (#239) * Revised implementation of reporting of external impacts Signed-off-by: Dennis Behm <[email protected]> * Revisions to Function Overview of Report External Impacts Signed-off-by: Lauren Li <[email protected]> * Handle case with back-level DBB server Signed-off-by: Dennis Behm <[email protected]> Signed-off-by: Dennis Behm <[email protected]> Signed-off-by: Lauren Li <[email protected]> Co-authored-by: Lauren Li <[email protected]> Signed-off-by: Dennis Behm <[email protected]> Signed-off-by: Lauren Li <[email protected]> Co-authored-by: Luke Burgess <[email protected]> Co-authored-by: Luke Burgess <[email protected]> Co-authored-by: Dennis Behm <[email protected]> Co-authored-by: Lauren Li <[email protected]> * remove another merge conflict * remove leftover RepositoryClient references after merge Signed-off-by: Dennis Behm <[email protected]> Signed-off-by: Lauren Li <[email protected]> Co-authored-by: Dennis Behm <[email protected]> Co-authored-by: Dan Bruce <[email protected]> Co-authored-by: Luke Burgess <[email protected]> Co-authored-by: Lauren Li <[email protected]>
dennis-behm
deleted the
227-hard_coded_library_name_in_assembler_language_script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assembler.groovylanguage script contained a hard coded library name, which was used to pull in a macro from a sample library for one of our Assembler test programs.The section was removed + commented out. Users should rather use the
assembler_assemblySyslibConcatenationto provide a custom syslib concatenation.I am not aware (and have not found) that a specific library needs to be passed to the assembler compiler for asm/db2 programs.