Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify obtaining the playbackDependency #311

Merged

Conversation

dennis-behm
Copy link
Member

This is simplifying the ZUnitConfig.groovy and fixes #390

@drbruce-git drbruce-git self-requested a review January 29, 2023 15:09
Copy link
Collaborator

@drbruce-git drbruce-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the result of running the automated zAppBuild tests?
Does it make sense to add new test cases for this code change?

@dennis-behm
Copy link
Member Author

@drbruce-git
I agree, that a new test case for this section of the code makes sense. However, the code change is very small.
I think it requires to add a new test application, which includes a IDZ zunit test configuration. Let's treat this as a separate issue. Would you be okay with this approach?

@drbruce-git
Copy link
Collaborator

@dennis-behm OK we can table the new test case for zunit testing for later. However can we still get the results of the existing regression tests? Also we need to figure out how to add a successful regression test run to the PR checks.

@dennis-behm
Copy link
Member Author

@drbruce-git

Here is the test bucket, which I ran against my branch:

This is the repo:

Cloning the remote Git repository
Cloning repository https://github.com/dennis-behm/dbb-zappbuild.git
 > git init /var/jenkins/workspace/dbb-zappbuild-testframework-withParms # timeout=10
Fetching upstream changes from https://github.com/dennis-behm/dbb-zappbuild.git
 > git --version # timeout=10
 > git --version # 'git version 2.26.2-78'
 > git fetch --tags --force --progress -- https://github.com/dennis-behm/dbb-zappbuild.git +refs/heads/*:refs/remotes/origin/* # timeout=10
Avoid second fetch
Checking out Revision 0ad49d4b93a51ee6b62ec22a985030bcf1f9d26e (origin/309_Zunit_without_playbackfile_develop)
Commit message: "Simplify obtaining the playbackDependency"
First time build. Skipping changelog.

My (testing) pipeline includes a full build for our internal catalog application:

*** Resolution rules for catalog-manager/testcfg/DFH0XVDS.bzucfg:
search:[SYSPLAY:]/var/jenkins/workspace/dbb-zappbuild-testframework-withParms/catalog-manager/?path=catalog-manager/testplayfiles/*.plbck
*** Physical dependencies for catalog-manager/testcfg/DFH0XVDS.bzucfg:
{"excluded":true,"lname":"DFH0XVDS","library":"SYSPROG","category":"ZUNITINC","resolved":false}
{"excluded":true,"lname":"TDFH0XVD","library":"SYSTEST","category":"ZUNITINC","resolved":false}
{"excluded":false,"sourceDir":"\/var\/jenkins\/workspace\/dbb-zappbuild-testframework-withParms\/catalog-manager\/","lname":"DFH0XVDS","library":"SYSPLAY","file":"catalog-manager\/testplayfiles\/DFH0XVDS.plbck","category":"ZUNITINC","resolved":true}
//RUNZUNIT JOB ,MSGCLASS=H,CLASS=A,NOTIFY=&SYSUID,REGION=0M
//*
//BADRC   EXEC PGM=IEFBR14
//DD        DD DSN=&SYSUID..BADRC,DISP=(MOD,CATLG,DELETE),
//             DCB=(RECFM=FB,LRECL=80),UNIT=SYSALLDA,
//             SPACE=(TRK,(1,1),RLSE)
//*
//* Action: Run Test Case...
//RUNNER EXEC PROC=BZUPPLAY,
// BZUCFG=JENKINS.DBB.TEST.CTLGMGR.BZU.BZUCFG(DFH0XVDS),
// BZUCBK=JENKINS.DBB.TEST.CTLGMGR.TEST.LOAD,
// BZULOD=JENKINS.DBB.TEST.CTLGMGR.LOAD,
//  PARM=('STOP=E,REPORT=XML,TIMESTAMP=C')
//REPLAY.BZUPLAY DD DISP=SHR, 
// DSN=JENKINS.DBB.TEST.CTLGMGR.BZU.BZUPLAY(DFH0XVDS)   < .....<...... JCL is correctly inserting the playback file name
//REPLAY.BZURPT DD DISP=SHR,
// DSN=JENKINS.DBB.TEST.CTLGMGR.BZU.BZURPT(DFH0XVDS)
//*
//IFGOOD IF RC<=4 THEN
//GOODRC  EXEC PGM=IEFBR14
//DD        DD DSN=&SYSUID..BADRC,DISP=(MOD,DELETE,DELETE),
//             DCB=(RECFM=FB,LRECL=80),UNIT=SYSALLDA,
//             SPACE=(TRK,(1,1),RLSE)
//       ENDIF

***  zUnit Test Job RUNZUNIT(JOB00543) completed with 0 
****************** Module [TDFH0XVD] ******************
Name:       TDFH0XVD
Status:     pass
Test cases: 1 (1 passed, 0 failed, 0 errors)

@drbruce-git drbruce-git self-requested a review February 16, 2023 18:17
@dennis-behm dennis-behm merged commit 01fc2bc into IBM:develop Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants