Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mermaid experiment - draft not for merging #422

Closed
wants to merge 6 commits into from

Conversation

ijmitch
Copy link
Member

@ijmitch ijmitch commented Oct 3, 2023

This PR is purely opened as a means to discuss the experimental use of Mermaid GitGraphs in place of the Powerpoint originated PNGs.

@ijmitch
Copy link
Member Author

ijmitch commented Oct 3, 2023

Compared to the PNG we only get the core Git information and lose the ability to include where builds happen and how testing happens.

But once you establish the principle that every branch can at least run a pipeline build, branches must build error-free as a condition of merging and every build can be deployed to a test environment, what else is left to say?

@ijmitch
Copy link
Member Author

ijmitch commented Oct 5, 2023

The last two commits workaround the unexpected routing and colour choice when two merges are immediately adjacent:

image

Adding a commit in between gives a less surprising outcome:

image

@ijmitch
Copy link
Member Author

ijmitch commented Oct 5, 2023

I've asked in the Mermaid Slack if anyone can explain our surprise at the line route and colour which I just worked around - https://mermaid-talk.slack.com/archives/CL256P19N/p1696494561191749

@ijmitch
Copy link
Member Author

ijmitch commented Oct 5, 2023

Discussed in the Mermaid Slack and agreed to open a new issue mermaid-js/mermaid#4912

@ijmitch ijmitch closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant