Fixing timestamp issue and adding decoration #425
Conversation
Signed-off-by: Mathieu Dalbin <[email protected]>
|
@M-DLB Thank you for the updates. https://github.com/M-DLB/dbb-zappbuild/blob/Fix-Timestamp/build-conf/build.properties#L108 defines also a valid time stamp. It is a bit of a "chicken and the egg" issue here, I guess, if we use the hard-coded vs the property-defined value. Anyway, should we move to a 24-h format generally to be more consistent? We could simplify the code and remove the property. |
|
I was not aware of this property! I think it makes sense to remove it, and only use the |
|
Hi @M-DLB ,
The buildOutputTSformat has been added to use the 24 hour format I would rather go for the 24 format for all, then :-) |
Signed-off-by: Mathieu Dalbin <[email protected]>
build-conf/README.md
Outdated
| @@ -41,7 +41,7 @@ applicationDefaultPropFiles | Comma separated list of default application confi | |||
| buildListFileExt | File extension that indicates the build file is really a build list. | |||
| applicationConfRootDir | Alternate root directory for application-conf location. Allows for the deployment of the application-conf directories to a static location. Defaults to ${workspace}/${application} | |||
| createBuildOutputSubfolder | Option to create a subfolder with the build label within the build output dir (outDir). Default: true. | |||
| buildOutputTSformat | Defines the build timestamp format for build output subfolder and build label. | |||
| (Deprecated) buildOutputTSformat | Defines the build timestamp format for build output subfolder and build label. | |||
There was a problem hiding this comment.
@M-DLB Let's completely drop the buildOutputTSformat property. It is no longer used in your implementation anyway.
There was a problem hiding this comment.
Alright, but it should be part of the changelog that this property no longer exists.
Signed-off-by: Mathieu Dalbin <[email protected]>
Signed-off-by: Mathieu Dalbin <[email protected]>
There was a problem hiding this comment.
@M-DLB Thanks for the updates. This makes it more consistent. A info message needs to be added to the release notes, that the timestamp now leverages the 24-h format for labels of the build result, the build directory (if used) etc.
This PR is fixing the problem reported here, plus additional issues (error when displaying the list of input arguments, decoration to identify the different steps of the build process).