Missing sortBuildMap function for language script zCEE2 #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu Dalbin <[email protected]>
dennis-behm
reviewed
Jan 17, 2024
utilities/BuildUtilities.groovy
Outdated
| /* | ||
| * sortBuildMap - sorts a build Map by rank property values | ||
| */ | ||
| def sortBuildMap(HashMap<String, String> buildMap, String rankPropertyName) { |
There was a problem hiding this comment.
Could we call this sortBuildListMap ?
Build Map is a reserved term, and might be confusing.
There was a problem hiding this comment.
Agreed, did the changes accordingly.
Signed-off-by: Mathieu Dalbin <[email protected]>
Signed-off-by: Mathieu Dalbin <[email protected]>
dennis-behm
reviewed
Jan 19, 2024
languages/zCEE2.groovy
Outdated
| @@ -123,11 +123,14 @@ sortedList.each { buildFile, inputType -> | |||
| StringBuffer shellError = new StringBuffer() | |||
|
|
|||
| String JAVA_HOME = props.getFileProperty('zcee2_JAVA_HOME', buildFile) | |||
There was a problem hiding this comment.
@M-DLB .
Can we probably use javaHome as a variable name, instead of the environment variable name?
Signed-off-by: Mathieu Dalbin <[email protected]>
dennis-behm
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the z/OS Connect EE 2 processing, where the sortBuildMap() function is used but is missing from the BuildUtilities.groovy script.