Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for REXX properties #552

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

M-DLB
Copy link
Collaborator

@M-DLB M-DLB commented Oct 14, 2024

Fixing issue #548
The PR adds some checks and use defaults values if these properties are not set. They are set by default in the REXX.properties file of application-conf folder.

Copy link
Member

@dennis-behm dennis-behm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @M-DLB,

these updates feel odd to me.

zAppBuild has the following capabilities:

  • Enforce the presence of build properties via the rexx_requiredBuildProperties list in build-conf. Looks like that these properties are missing there.
  • and the capability to set defaults - probably via the central applicationDefaultPropFiles setting in build.properties if the customer is looking for centrally controlling it.

Any specific reasoning to hard-code the defaults in the script itself?

@M-DLB
Copy link
Collaborator Author

M-DLB commented Oct 14, 2024

You're right it's odd. It is just a workaround for people who are trying to use zAppBuild to build REXX programs, without having taken REXX.properties from samples/application-conf/ and put that in the application's application-conf.
I'm happy to kill this PR, as long as we accept that we have the same problem with all our other scripts. For instance Cobol.properties in build-conf doesn't require cobol_compileMaxRC, cobol_linkEditMaxRC and cobol_linkEdit which are set in Cobol.properties of application-conf, and Cobol.groovy is using them.
What do you think?

@dennis-behm
Copy link
Member

@M-DLB

You're right it's odd. It is just a workaround for people who are trying to use zAppBuild to build REXX programs, without having taken REXX.properties from samples/application-conf/ and put that in the application's application-conf.

Let's see this as a broader initiative to reconcile how properties are set. It is time to make use of applicationDefaultPropFiles and reduce the settings in application-conf, and review the required build properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants