Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary Build #18

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Binary Build #18

merged 1 commit into from
Oct 17, 2022

Conversation

mbwhite
Copy link
Contributor

@mbwhite mbwhite commented Oct 17, 2022

PR github action to build binary files

(release action will be follow-on)

Signed-off-by: Matthew B White [email protected]

ale-linux
ale-linux previously approved these changes Oct 17, 2022
PR github action to build binary files
Attaches binaries to the PR action
Update to the latest actions

Signed-off-by: Matthew B White <[email protected]>
@mbwhite mbwhite marked this pull request as ready for review October 17, 2022 09:12
@@ -5,16 +5,18 @@ on:
branches: [ main ]
pull_request:
branches: [ main ]
workflow_dispatch:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it permits the Maintainers/Admins of the repo manually trigger the workflow from the UI.
Majority of the time this isn't actually needed. But we've found that it is very useful in exceptional circumstances to be able to trigger a workflow manually. So it's a 'safety feature' for the future.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack - thx!

@@ -5,16 +5,18 @@ on:
branches: [ main ]
pull_request:
branches: [ main ]
workflow_dispatch:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack - thx!

@ale-linux ale-linux merged commit 29f75a0 into IBM:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants