-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary Build #18
Binary Build #18
Conversation
PR github action to build binary files Attaches binaries to the PR action Update to the latest actions Signed-off-by: Matthew B White <[email protected]>
@@ -5,16 +5,18 @@ on: | |||
branches: [ main ] | |||
pull_request: | |||
branches: [ main ] | |||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it permits the Maintainers/Admins of the repo manually trigger the workflow from the UI.
Majority of the time this isn't actually needed. But we've found that it is very useful in exceptional circumstances to be able to trigger a workflow manually. So it's a 'safety feature' for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack - thx!
@@ -5,16 +5,18 @@ on: | |||
branches: [ main ] | |||
pull_request: | |||
branches: [ main ] | |||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack - thx!
PR github action to build binary files
(release action will be follow-on)
Signed-off-by: Matthew B White [email protected]