Remove hardcoded position 0 for user secret key
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecaro
previously approved these changes
Aug 26, 2024
| @@ -158,14 +158,14 @@ type SignatureScheme interface { | |||
| // rhIndex: revocation handle index relative to attributes; | |||
| // revocationPublicKey: revocation public key; | |||
| // epoch: revocation epoch. | |||
| Verify(ipk IssuerPublicKey, signature, msg []byte, attributes []IdemixAttribute, rhIndex, eidIndex int, | |||
| Verify(ipk IssuerPublicKey, signature, msg []byte, attributes []IdemixAttribute, rhIndex, eidIndex, skIndex int, | |||
There was a problem hiding this comment.
can you update the comment, please?
This PR removes the hardcoded position 0 for the user secret key. Until now, the attribute position of the user secret key was 0. This is too restrictive since it forbids the usage of other schemas (e.g. JSON-LD) where the position of the attributes depends on the serialisation rules, and we cannot guarantee position 0. Signed-off-by: Alessandro Sorniotti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the hardcoded position 0 for the user secret key. Until now, the attribute position of the user secret key was 0. This is too restrictive since it forbids the usage of other schemas (e.g. JSON-LD) where the position of the attributes depends on the serialisation rules, and we cannot guarantee position 0.