Extended Idemix Signature Sig Algorithm #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Additional of the EID commitment to the metadata - Ability to generate an Idemix signature against an already existing EDI commitment and its opening Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
the signature carries the same nymID Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
ale-linux
requested changes
Nov 3, 2021
| @@ -841,6 +869,28 @@ func (sig *Signature) Ver( | |||
| if !Nym_eid.Equals(EidNym) { | |||
| return errors.Errorf("signature invalid: nym eid validation failed") | |||
| } | |||
|
|
|||
| if !meta.NymEIDAuditData.Nym.Equals(EidNym) { | |||
There was a problem hiding this comment.
what if meta is nil, or some of the fields you deref?
There was a problem hiding this comment.
I have reversed the variable. This should be safe
There was a problem hiding this comment.
Just to double-check, if you supply a Nil argument to Equals, will it fail gracefully?
There was a problem hiding this comment.
this depends on the underlying math library. Anyhow, if a panic happens it is caught in the upper layers.
Anyhow, let me add an explicit check :)
Signed-off-by: Angelo De Caro <[email protected]>
ale-linux
requested changes
Nov 4, 2021
| Nym_eid := H_a_eid.Mul2(meta.NymEIDAuditData.EID, HRand, meta.NymEIDAuditData.RNymEid) | ||
| if !Nym_eid.Equals(EidNym) { | ||
| return errors.Errorf("signature invalid: nym eid validation failed") | ||
| if len(meta.NymEID) != 0 { |
There was a problem hiding this comment.
This whole block is untested right?
ale-linux
requested changes
Nov 4, 2021
go.mod
Outdated
| @@ -7,13 +7,15 @@ require ( | |||
| github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751 // indirect | |||
| github.com/alecthomas/units v0.0.0-20210912230133-d1bdfacee922 // indirect | |||
| github.com/golang/protobuf v1.3.3 | |||
| github.com/google/addlicense v1.0.0 // indirect | |||
There was a problem hiding this comment.
Can you pls revert these changes? This package is actually not needed, we only use it for the CI run
go.mod
Outdated
| github.com/hyperledger/fabric-protos-go v0.0.0-20210911123859-041d13f0980c | ||
| github.com/onsi/ginkgo v1.14.0 | ||
| github.com/onsi/gomega v1.10.1 | ||
| github.com/pkg/errors v0.9.1 | ||
| github.com/stretchr/testify v1.7.1-0.20210116013205-6990a05d54c2 // includes ErrorContains | ||
| github.com/sykesm/zap-logfmt v0.0.2 | ||
| go.uber.org/zap v1.16.0 | ||
| golang.org/x/sync v0.0.0-20210220032951-036812b2e83c // indirect |
- additional tests - check for nil meta.NymEIDAuditData.Nym Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
ale-linux
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings:
Signed-off-by: Angelo De Caro [email protected]