🐛 Fix nested lazy import and sys meta path modification issue #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-l-hart
requested changes
Aug 2, 2022
There was a problem hiding this comment.
Thanks @gkumbhat! There are two cleanup steps to get the tests to pass:
make fmtgit fetch origin && git rebase --signoff origin/main
gkumbhat
force-pushed
the
fix_nested_lazy_import
branch
from
092b2f9
to
50e173f
Compare
gabe-l-hart
requested changes
Aug 2, 2022
import_tracker/lazy_import_errors.py
Outdated
| sys.meta_path.pop() | ||
| if self.finder in sys.meta_path: | ||
| sys.meta_path.remove(self.finder) | ||
| # while sys.meta_path and isinstance(sys.meta_path[-1], _LazyErrorMetaFinder): |
There was a problem hiding this comment.
Please remove these dead lines
gabe-l-hart
approved these changes
Aug 2, 2022
Signed-off-by: Gaurav-Kumbhat <[email protected]>
Signed-off-by: Gaurav-Kumbhat <[email protected]>
Signed-off-by: Gaurav-Kumbhat <[email protected]>
gkumbhat
force-pushed
the
fix_nested_lazy_import
branch
from
1a38981
to
193f288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
sys.meta_pathis modified (appended) by some other library. This issue was noticed whensys.meta_pathwas getting modified bysetuptools.command.build_py.