Add fix for typing #65
Conversation
gkumbhat
force-pushed
the
add_fix_for_typing
branch
2 times, most recently
from
68958df
to
3230c1f
Compare
import_tracker/lazy_import_errors.py
Outdated
| self._raise() | ||
| if not _is_import_time(): | ||
| self._raise() | ||
| return randint(0, 100000000) |
There was a problem hiding this comment.
I don't like using randint here. How about id(self)? Nondeterminism scares me.
There was a problem hiding this comment.
Ah yes. That would be better.. Will change this
import_tracker/lazy_import_errors.py
Outdated
| @@ -530,3 +544,9 @@ def _get_non_import_modules(cls): | |||
| for frame in cls._FrameGenerator() | |||
| ), | |||
| ) | |||
|
|
|||
|
|
|||
| def _is_import_time(): | |||
There was a problem hiding this comment.
I think this will be caught in the other PR, but this needs a docstring and type hint
There was a problem hiding this comment.
yep, will add that. This PR would need rebasing after the other one gets merged
gkumbhat
force-pushed
the
add_fix_for_typing
branch
from
3230c1f
to
49a0320
Compare
Signed-off-by: Gaurav-Kumbhat <[email protected]>
Signed-off-by: Gaurav-Kumbhat <[email protected]>
Signed-off-by: Gaurav-Kumbhat <[email protected]>
gkumbhat
force-pushed
the
add_fix_for_typing
branch
from
49a0320
to
e94db07
Compare
| @@ -244,7 +242,8 @@ def __delitem__(self, *_, **__): | |||
| self._raise() | |||
|
|
|||
| def __eq__(self, *_, **__): | |||
| self._raise() | |||
| if not _is_import_time(): | |||
There was a problem hiding this comment.
This should return a bool if _is_import_time is true
There was a problem hiding this comment.
Ah yes, good point! Like the function __eq__ would need to return bool?
I guess currently it would return None which would be falsey, so may be we should return False if _is_import_time is True?
Signed-off-by: Gaurav-Kumbhat <[email protected]>
Changes
based on #64
Scenarios
Dict[foo, str]Union[foo, str]Typing is another one of the operations that happens at the import time.
In both above scenarios, a hashing is performed under the hood in python that tries to make a unique combination of the presented types. Since we are replacing it with lazy module, without this fix, we are raising error for
__hash__function, and thus the typing at import time, throws error.