⚡ Remove inspect.stack() for performance #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Runde <[email protected]>
joerunde
force-pushed
the
faster-imports
branch
from
f47d566
to
f7e7e6e
Compare
Signed-off-by: Joe Runde <[email protected]>
joerunde
force-pushed
the
faster-imports
branch
from
4ceae49
to
99798ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not gonna lie I don't fully understand what's going on inside of
inspect.stack()to make it so much slower than iterating throughsys._getframe()but here we are.This takes a partial import of a library that makes heavy use of
abc.ABCfrom 650s back down to 4s.