Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for cp4na issue 264: dynamic value population for readyCheck #45

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

dushyantbehl
Copy link
Contributor

Added support for dynamic value population in check ready script and it's name.
Also added a unit test for the same.

Tested with following example on CP4NA v2.1 -

compose:
  - name: Create
    deploy:
      - helm:
          chart: apache-7.3.15.tgz
          name: r{{ system_properties.resource_id_label }}
          namespace: default
          values: "apache-helm-chart-values.yaml"
    checkReady:
      script: "{{ nameCheck }}.py"

@dvaccarosenna dvaccarosenna self-requested a review July 1, 2021 14:39
@dvaccarosenna
Copy link
Member

Fixes #46

@dvaccarosenna dvaccarosenna merged commit 01a42dc into IBM:develop Jul 1, 2021
@dushyantbehl dushyantbehl deleted the cp4na-issue-264 branch July 2, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants