Change semverCompare in PDB #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ognyvrac <[email protected]>
ognyvrac
force-pushed
the
ognyvrac-patch-1
branch
from
13a9b9c
to
3a73021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are experiencing some issues with the
semverComparelogic inside the PDB of the Helm chart as it cannot handle the Kubernetes GitVersion for clusters on GKE.The output of running
kubectl version:.Capabilities.KubeVersion.GitVersionlooks at the GitVersion of the Kubernetes cluster; in our case that is a GKE cluster which has the GitVersion ofGitVersion:"v1.24.16-gke.500"(retrieved by runningkubectl version). The issue stems from the-gke.500which according to the Helm docs is considered as a pre-release.The solution provided seems to work both with GitVersion without a pre-release, such as
1.20.0or1.24.0, and GitVersions with a pre-release, such as1.20.0-alphaandv1.21.0-beta.500-orca.It should be considered that adding
-0to the semverCompare string will be treated as a "pre-release" and that is not the case for GKE with its-gke.500.Another solution that removes this "pre-release" concern could be
{{- if and (eq 1 (int .Capabilities.KubeVersion.Major)) (ge (int .Capabilities.KubeVersion.Minor) 21) -}}- not as clean, but more understandable and error-proof.