remove rack from FindCoordinatorResponse #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncode version to 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1050 introduced the
Rack-field to theFindCoordinatorResponse, however this is only part of theMetadataResponse. As we now have a shared method for decoding/encoding the broker for both these messages we can work around this (as was pre-#1050) by hard coding the version of the coordinator-decode to 0.Ultimately I guess we should separate the decoding of the broker for these two messages, but maybe we should leave that for another day.
This removes the rack from the
FindCoordinatorResponseand hardcodes theBrokerdecode/encodeversion to 0 and adds a comment for that.cc @horkhe