Shrink the scope of the partition circuit-breaker #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eapache
force-pushed
the
shrink-partitioner-breaker
branch
from
0cba7e3
to
e3a4139
Compare
|
I think this should fix #466. How hard would it be to construct a test for this? |
|
A test that partitioner errors are not part of the breaker, or a test that |
|
I think a test for a custom partitioner would be good. We explicitly designed to allow this but it's not really tested. The fact that it should be not part of the circuit breaker could be part of it. A test for having |
|
test added; ended up touching a lot of lines because I generalized 👀 when ready |
eapache
force-pushed
the
shrink-partitioner-breaker
branch
from
80c605f
to
b21ab84
Compare
It shouldn't wrap the entirety of `assignPartition`, since that also protects things like the call to actually choose the partition. The only thing it is supposed to protect is the call to get the list of partitions, since that is what can block.
|
LGTM 👍 |
eapache
added a commit
that referenced
this pull request
Jun 9, 2015
Shrink the scope of the partition circuit-breaker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It shouldn't wrap the entirety of
assignPartition, since that also protectsthings like the call to actually choose the partition. The only thing it is
supposed to protect is the call to get the list of partitions, since that is
what can block.
This may or may not fix (or be the right way to fix) #466.
@ssahukar @Shopify/kafka