Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eagle-1194: Remove 'keyAttribute' attribute from 'field' structure in graph JSON #274

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

james-strauss-uwa
Copy link
Collaborator

We are moving away from the 'keyAttribute' system and towards using a Graph Configuration to overwrite specific parameters in a Logical Graph Template.

Copy link
Contributor

sourcery-ai bot commented Jul 23, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @james-strauss-uwa - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@james-strauss-uwa
Copy link
Collaborator Author

I guess I need to re-generate the pickled versions of the graphs in daliuge-translator/test/dropmake/pickle/

@myxie
Copy link
Collaborator

myxie commented Sep 25, 2024

@james-strauss-uwa this is another one I have missed. I am assuming these changes will need to be merged at some point; I am wondering if you would be okay with me doing the changes at the same time I created the new entry in EAGLE_test_repo?

@james-strauss-uwa
Copy link
Collaborator Author

@myxie Yes, that would be great thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants