20230116 A Transform to ignore artefact points #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichelDaab On mergera d'abord ta PR, pour éviter de nouveaux conflits ;) |
… behavior Tests pass for DropPointsByClass Copy full position BEFORE droping by class to avoid error at knn_interpolate More test for DropPointsByClass creation Flake8
CharlesGaydon
force-pushed
the
20230116-ignoring-artefacts-transform
branch
from
164e6d0
to
669ee4c
Compare
|
@MichelDaab Prêt pour revue :) Est-ce que tu penses pouvoir la faire lundi ? Il n'y a pas une urgence énorme mais c'est une amélioration utile en prod :) |
|
Ils sont bien ignorés. |
MichelDaab
requested changes
Feb 6, 2023
There was a problem hiding this comment.
Ma principale remarque est que les instantiations par hydra sont super relou à remonter quand on n'est pas à l'origine de l'arborescence et qu'on doit chercher ce que fait une modification.
Autement il y a deux-trois petites choses mineures que j'ai vues passer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Création d'une transform
DropPointsByClassqui permet d'ignorer les points appartenant à la classe 65 (artefacts). Possibilité de remapper d'autres classes vers 65 en amont.Les points sont gardés dans le nuage de point final, et conservent leur classe initiale, et ont probas et entropie à 0.
Testé + documenté.