fix: support edge case where src LAZ has no valid patch #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s False) A HDF5 group for the src file is not created if all patches included in a source laz do not pass the pre_filter step. This typically happens in clouds with a low or null number of points, when pre_filter requires a larger number of points than available.
CharlesGaydon
changed the title
CharlesGaydon
changed the title
|
STATUS: en attente de validation que le fix fonctionne |
|
Validé par @MichelDaab. |
leavauchier
approved these changes
Sep 14, 2023
|
Merci ! |
CharlesGaydon
deleted the
patch-support-empty-tiles-in-hdf5-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling a special case, usually due to invalid input data but that can also happen in normal situations.
I also correct a line for the deletion of incomplete hdf5 group. The wrong group was deleted, which would just mean starting the whole creation of hdf5 groups for a split (train/test/val) instead of resuming to where the creation was stopped.