Updated function synchronization code between window and `IITC.util…

…s` to support renamed functions
IITC-CE · Oct 31, 2024 · c171353 · c171353
1 parent 4a3362b
commit c171353
Showing 1 changed file with 40 additions and 38 deletions.
diff --git a/core/code/utils.js b/core/code/utils.js
@@ -595,49 +595,51 @@ IITC.utils = {
   makePermalink,
 };
 
-// List of functions to track for synchronization between window.* and IITC.utils.*
-const legacyFunctions = [
-  'getURLParam',
-  'readCookie',
-  'writeCookie',
-  'eraseCookie',
-  'digits',
-  'zeroPad',
-  'unixTimeToString',
-  'unixTimeToDateTimeString',
-  'unixTimeToHHmm',
-  'formatInterval',
-  'formatDistance',
-  'rangeLinkClick',
-  'showPortalPosLinks',
-  'isTouchDevice',
-  'scrollBottom',
-  'zoomToAndShowPortal',
-  'selectPortalByLatLng',
-  'escapeJavascriptString',
-  'escapeHtmlSpecialChars',
-  'prettyEnergy',
-  'uniqueArray',
-  'genFourColumnTable',
-  'convertTextToTableMagic',
-  'clamp',
-  'clampLatLng',
-  'clampLatLngBounds',
-  'pnpoly',
-  'makePrimeLink',
-  'makePermalink',
-];
-
-legacyFunctions.forEach((funcName) => {
-  window.IITC.utils[funcName] = window.IITC.utils[funcName] || function () {};
+// Map of legacy function names to their new names (or the same name if not renamed)
+const legacyFunctionMappings = {
+  getURLParam: 'getURLParam',
+  readCookie: 'getCookie',
+  writeCookie: 'setCookie',
+  eraseCookie: 'deleteCookie',
+  digits: 'formatNumber',
+  zeroPad: 'zeroPad',
+  unixTimeToString: 'unixTimeToString',
+  unixTimeToDateTimeString: 'unixTimeToDateTimeString',
+  unixTimeToHHmm: 'unixTimeToHHmm',
+  formatInterval: 'formatInterval',
+  formatDistance: 'formatDistance',
+  rangeLinkClick: 'rangeLinkClick',
+  showPortalPosLinks: 'showPortalPosLinks',
+  isTouchDevice: 'isTouchDevice',
+  scrollBottom: 'scrollBottom',
+  zoomToAndShowPortal: 'zoomToAndShowPortal',
+  selectPortalByLatLng: 'selectPortalByLatLng',
+  escapeJavascriptString: 'escapeJavascriptString',
+  escapeHtmlSpecialChars: 'escapeHtmlSpecialChars',
+  prettyEnergy: 'prettyEnergy',
+  uniqueArray: 'uniqueArray',
+  genFourColumnTable: 'genFourColumnTable',
+  convertTextToTableMagic: 'convertTextToTableMagic',
+  clamp: 'clamp',
+  clampLatLng: 'clampLatLng',
+  clampLatLngBounds: 'clampLatLngBounds',
+  pnpoly: 'isPointInPolygon',
+  makePrimeLink: 'makePrimeLink',
+  makePermalink: 'makePermalink',
+};
+
+// Set up synchronization between `window` and `IITC.utils` with new names
+Object.entries(legacyFunctionMappings).forEach(([oldName, newName]) => {
+  // Initialize IITC.utils[newName] if not already defined
+  window.IITC.utils[newName] = window.IITC.utils[newName] || function () {};
 
   // Define a getter/setter on `window` to synchronize with `IITC.utils`
-  Object.defineProperty(window, funcName, {
+  Object.defineProperty(window, oldName, {
     get() {
-      return window.IITC.utils[funcName];
+      return window.IITC.utils[newName];
     },
     set(newFunc) {
-      window.IITC.utils[funcName] = newFunc;
+      window.IITC.utils[newName] = newFunc;
     },
     configurable: true,
   });