Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmarks not showing #645

Closed
BountyHunter23 opened this issue Jul 8, 2023 · 16 comments
Closed

Bookmarks not showing #645

BountyHunter23 opened this issue Jul 8, 2023 · 16 comments

Comments

@BountyHunter23
Copy link

IITC 0.35.1 [release]
Bookmarks plugin 0.4.2
No bookmarks option available in the IITC menu and can not create new bookmarks.
Other plugins in use: Draw Tooks, Wasabee, Bannergress, Machina and others.
@xscreach
Copy link
Contributor

xscreach commented Jul 8, 2023

Tested on IITC 0.35.1 both PC and Mobile + Bookmarks plugin 0.4.2

Bookmark portal (star) available and working creating/removing new portla bookmark.
Bookmark window/pane available - ability to create/remove bookmars for maps.
Bookmark highlighter and Bookmarked Portals layer also working showing bookmarked portals on map (each it's own way).

Suggestion - remove any plugin that might interfere with these.
Note that bookmarks plugin hasn't been changed since Jul 26, 2022.

If that does not help try to provide more information like:

  • platform you are using (mobile/pc, tampermonkey/greasemonkey/IITC button, android/ios)
  • console logs from developer options (F12 on PC) or from debug console on mobile

image
image
image
image

@MysticJay
Copy link
Contributor

Please show your "About IITC" from the toolbox.
If you have Faction-only plugins that should not be shown, either disable them first from Tampermonkey or send the screenshot to a DEV of your faction in Telegramm.

@MysticJay
Copy link
Contributor

@BountyHunter23 does the issue persist?

@BountyHunter23
Copy link
Author

BountyHunter23 commented Jan 21, 2024 via email

@xscreach
Copy link
Contributor

@BountyHunter23 imho it would be best if you came to visit us on telegram - https://t.me/+1xncfR_TV3BjZTIy

We could try to solve the issue "live" 😉

Because we'll need some more information from you...
Like screenshots of:

  • "about IITC" dialog - if you have some plugins you don't want people to know about, disable them first
  • developer console output - press F12 and check tab "console" for red lines

And some description of what you are missing and where.
Something like:

  • there should be a star ⭐ in info panel but I don't see that
  • nothing happens when I click the star in info panel
  • I can click the star, it changes colour, but I don't see change in bookmark list
  • etc...

All of that and maybe more will be needed before we can even start trying to figure out what's going on 🤷

@BountyHunter23
Copy link
Author

BountyHunter23 commented Jan 22, 2024 via email

@Ashayazu
Copy link

Hello, I seems to have a similair issue with the bookmarks plugin. it seems to work on my phone and tablet but I cannot make bookmarks in chrome/firefox on PC with neither IITC Button or tampermonkey.

These are the errors from the console when I press the star button and Write Bookmarks button from FanFields2:

324f024f850242880d2168a1f587b2fd

VM461:396
    Uncaught 
        TypeError: Cannot read properties of undefined (reading 'idOthers')
            at window.plugin.bookmarks.addPortalBookmarkByMarker (<anonymous>:396:47)
            at window.plugin.bookmarks.addPortalBookmarkByGuid (<anonymous>:428:29)
            at window.plugin.bookmarks.switchStarPortal (<anonymous>:375:29)
            at HTMLAnchorElement.onclick (intel:1:25)

        window.plugin.bookmarks.addPortalBookmarkByMarker @ VM461:396 
        window.plugin.bookmarks.addPortalBookmarkByGuid @ VM461:428 
        window.plugin.bookmarks.SwitchStarPortal @ VM461:375 
        onclick @ intel:1 

(VM461:396) window.plugin.bookmarks.bkmrksObj['portals'][window.plugin.bookmarks.KEY_OTHER_BKMRK]['bkmrk'][ID] = {
(VM461:428) window.plugin.bookmarks.addPortalBookmarkByMarker(marker, doPostProcess);
(VM461:375) window.plugin.bookmarks.addPortalBookmarkByGuid(guid, true);
(intel:1) window.plugin.bookmarks.switchStarPortal();return false;

The Write Bookmarks button from FanFields2 does not work either and reports the following error

VM462:389 
    Uncaught 
        TypeError: Cannot set properties of undefined (setting 'id1721648581386452')
            at thisplugin.saveBookmarks (<anonymous>:389:62)
            at HTMLAnchorElement.onclick (intel:1:25)
       
        thisplugin.saveBookmarks @ VM642:389
        onclick @ intel:1

(VM642:389) window.plugin.bookmarks.bkmrksObj.portals[folder_ID] = {"label":label,"state":1,"bkmrk":{}};
(intel:1)          <!DOCTYPE html>

@Ashayazu
Copy link

Ashayazu commented Jul 22, 2024 •
edited
Loading

Small update, the problem migrated to my phone and tablet as well. I do not know how yet. I did not update any of the plugins on those devices. so it breaks over time looks like?

@DanielOndiordna
Copy link

I think your stored (localstorage) bookmark data is corrupt. Did you ever import bookmarks data?
The bookmarks plugin does not check for valid formatted import or stored data.
The only way to fix this, is to use the bookmarks menu to delete all bookmarks, or to manually delete the localstorage key for bookmarks.

@Ashayazu
Copy link

Ashayazu commented Jul 23, 2024 •
edited
Loading

I've never imported bookmarks. only used the sync plugin to match the data on my phone and tablet.
Deleting all bookmarks from the Bookmark Opt did not do anything. Now that I mention it when I reset the bookmarks and go to copy bookmarks after I get this in there:

[{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.102814,"lng":6.874248},{"lat":53.103173,"lng":6.872232}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.102814,"lng":6.874248},{"lat":53.103173,"lng":6.872232}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.103173,"lng":6.872232},{"lat":53.104405,"lng":6.86551},{"lat":53.103741,"lng":6.866543}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.103741,"lng":6.866543},{"lat":53.104228,"lng":6.865426}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.104405,"lng":6.86551},{"lat":53.103741,"lng":6.866543}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.103173,"lng":6.872232},{"lat":53.104405,"lng":6.86551}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.103173,"lng":6.872232},{"lat":53.103741,"lng":6.866543},{"lat":53.100874,"lng":6.86798}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.103741,"lng":6.866543},{"lat":53.104228,"lng":6.865426},{"lat":53.100874,"lng":6.86798}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.104228,"lng":6.865426},{"lat":53.100874,"lng":6.86798}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.101698,"lng":6.86669},{"lat":53.099702,"lng":6.867695}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.100874,"lng":6.86798},{"lat":53.101698,"lng":6.86669}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.100874,"lng":6.86798},{"lat":53.101698,"lng":6.86669},{"lat":53.099702,"lng":6.867695}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.099702,"lng":6.867695},{"lat":53.09886,"lng":6.867904}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.1047433806663,"lng":6.865189075469971},{"lat":53.10357108451815,"lng":6.861326694488525},{"lat":53.09919079422769,"lng":6.862828731536865},{"lat":53.09683620389092,"lng":6.870408654212952},{"lat":53.09660750220414,"lng":6.870601773262024},{"lat":53.09662360799652,"lng":6.870789527893066},{"lat":53.09912637486609,"lng":6.872012615203857},{"lat":53.10281100730497,"lng":6.8753814697265625}],"color":"#a24ac3"}]

Should it not be empty? thus maybe indicating local storage is broken? How do I go about manually deleting the localstorage key?

Edit: even removing tampermonkey and all the plugins related. does not fix the issue. Is there a local cache/file I need to remove in order for it to completely reset?

@DanielOndiordna
Copy link

That is Draw tools data. And due to sync it copied over from your pc to mobile. Not automatically "over time", it is something you must have done yourself accidentally at some point.
You can clear the bookmarks data on both pc and mobile by deleting the stored bookmarks data key.

@Ashayazu
Copy link

ok so far it looked like the synced bookmark database was corrupt. I managed to delete the bookmarks from my phone and let it sync up with the rest of my devices. I'm still not sure why I am not able reset it from my pc though.

one last question. On the pc version I have 2 extra buttons on the bookmarks menu.
Save box position and Reset box position.

d78ecda47c6ee5141199d2acf99d27be

Not sure what these do but I do not have the same options on mobile. All my platforms run the same plugins and versions:
0.4.4 [release] 2024-03-20-144515

@DanielOndiordna
Copy link

The "box" on the pc is the floating bookmarks list. You can drag it around.
On mobile, the list view is placed in a full screen area, from the side pane. You can not position this view.

@Ashayazu
Copy link

Unless you use desktop view on the mobile devices ;p. Anyway thanks for the input, it solved my issue albeit with a workaround.

@modos189 modos189 closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@modos189 @xscreach @MysticJay @DanielOndiordna @Ashayazu @BountyHunter23 and others