Proxy for chat and COMM API #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
modos189
force-pushed
the
comm_tabs_refactor_fix_legacy
branch
from
8b4608c
to
854f16c
Compare
modos189
force-pushed
the
comm_tabs_refactor_fix_legacy
branch
2 times, most recently
from
86754e8
to
4a747db
Compare
…functions from chat to comm
….comm.portalNameTransformations) so that you can extend transformation rules from plugins without having to rewrite the function
….messageTransformFunctions) so that plugin developers can add new message transformation rules or generate entirely new message markup without having to rewrite the function
…lter), implemented testing of the filter
…fault, the center of the map) is placed in the IITC.comm.getLatLngForSendingMessage() function.
modos189
force-pushed
the
comm_tabs_refactor_fix_legacy
branch
from
f03fc04
to
7fe9466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #447
Problem: legacy plugins overwrite window.chat functions, but the new code uses the COMM API and these plugin changes are not called. Also, before this PR, a lot of window.chat functions were removed, which could cause errors in the legacy plugins.
Solution: I created a proxy that calls the alternatives in the COMM API when calling the removed window.chat functions. It also overwrites COMM API methods when they are overwritten in window.chat by a legacy plugin.
I tested this solution with plugins from Commutity plugins and it looks like a working solution.