-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add break lines to makefile #612
Conversation
Thank you! What line break rule did you apply? What is the maximum line break length now that is permitted? |
Also did you try building an example to see if you didn't remove too much whitespace? |
I put line breaks when the command line was more extensive than the general commands and when there was more than one command in the same line. I was looking into a real Makefile (UBERON).
Looking better in the result, I'll fix some whitespaces. |
Try this on PATO and CL - there are a lot of empty lines generated in the resulting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its fine, but I wanted a brief look of @gouttegd when he is back just in case.
I will risk it. |
@matentzn I don’t see any problems with the changes. I would have broken some lines even more (especially for conditional constructs), but that’s a detail and/or a matter of taste. |
Fixes #553