Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add break lines to makefile #612

Merged
merged 5 commits into from
Jun 19, 2022
Merged

Add break lines to makefile #612

merged 5 commits into from
Jun 19, 2022

Conversation

anitacaron
Copy link
Contributor

Fixes #553

@anitacaron anitacaron requested a review from matentzn June 9, 2022 14:51
@matentzn
Copy link
Contributor

Thank you! What line break rule did you apply? What is the maximum line break length now that is permitted?

@matentzn
Copy link
Contributor

Also did you try building an example to see if you didn't remove too much whitespace?

@anitacaron
Copy link
Contributor Author

What line break rule did you apply? What is the maximum line break length now that is permitted?

I put line breaks when the command line was more extensive than the general commands and when there was more than one command in the same line. I was looking into a real Makefile (UBERON).

Also did you try building an example to see if you didn't remove too much whitespace?

Looking better in the result, I'll fix some whitespaces.

@matentzn
Copy link
Contributor

Try this on PATO and CL - there are a lot of empty lines generated in the resulting Makefile!

@anitacaron anitacaron self-assigned this Jun 14, 2022
@matentzn matentzn requested a review from gouttegd June 19, 2022 19:51
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its fine, but I wanted a brief look of @gouttegd when he is back just in case.

@matentzn matentzn added this to the 1.3.1 milestone Jun 19, 2022
@matentzn matentzn merged commit efa8d96 into master Jun 19, 2022
@matentzn matentzn deleted the anitacaron/issue553 branch June 19, 2022 20:21
@matentzn
Copy link
Contributor

I will risk it.

@gouttegd
Copy link
Contributor

@matentzn I don’t see any problems with the changes. I would have broken some lines even more (especially for conditional constructs), but that’s a detail and/or a matter of taste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format the Makefile a bit nicer using line breaks \
3 participants