Forward the host SSH agent socket into the container #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: * binds the SSH agent socket (as found in $SSH_AUTH_SOCK) from the host to a predictable location inside the container; * sets the SSH_AUTH_SOCK variable in the container to point to said predictable location. This allows processes running inside the container to communicate with the host's SSH agent and therefore to use the user's SSH keys without having to expose the keys directly to the container. closes #852
|
Thanks @gouttegd I will look at this after biocuration unless there is a reason to rush? |
|
No emergency as far as I am concerned. This may solve #848, if the user here is using a SSH agent (which they probably do). |
|
Ping @matentzn. This is very simple change that does not alter the behaviour of the ODK, except that it makes it possible to use SSH with agent-provided keys from within the container. |
matentzn
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
$SSH_AUTH_SOCK) from the host to a predictable location inside the container;SSH_AUTH_SOCKvariable in the container to point to said predictable location.This allows processes running inside the container to communicate with the host's SSH agent and therefore to use the user's SSH keys without having to expose the keys directly to the container.
closes #852