Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug that docs workflow is created during seeding #889

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Fix bug that docs workflow is created during seeding #889

merged 5 commits into from
Sep 28, 2023

Conversation

matentzn
Copy link
Contributor

No description provided.

adeans added a commit to adeans/gallont that referenced this pull request Jun 23, 2023
@adeans
Delete docs.yml
776f44b 
deleting as per suggested on Slack, regarding  INCATools/ontology-development-kit#889
@matentzn matentzn requested a review from anitacaron July 6, 2023 13:59
@matentzn
Copy link
Contributor Author

@anitacaron did you mean to approve this?

@anitacaron
Copy link
Contributor

The problem is the docs GitHub action that is created as default and the mkdocs.yml file is created with documentation option.

anitacaron
anitacaron requested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@anitacaron anitacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change the code in line 1769 or change the default value.

{% if (('github_actions' in project.ci) and ('docs' in project.workflows)) %}

@anitacaron
Copy link
Contributor

I can update the PR with your decision.

@anitacaron
Copy link
Contributor

The default workflow should be 'qc' instead of 'docs'.

@anitacaron anitacaron changed the title Fix bug that documentation files are created during seeding Fix bug that documentation workflow is created during seeding Jul 21, 2023
@anitacaron anitacaron changed the title Fix bug that documentation workflow is created during seeding Fix bug that docs workflow is created during seeding Jul 21, 2023
@anitacaron
Copy link
Contributor

Or no default at all.

@matentzn
Copy link
Contributor Author

Ok, I will let you decide how to move this forward :) Thank you!

matentzn
matentzn commented Sep 5, 2023
View reviewed changes
Copy link
Contributor Author

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this is the right way to go. If you have tested this you can merge it!

@matentzn matentzn merged commit 56ee5bc into master Sep 28, 2023
1 check passed
@matentzn matentzn deleted the bug-seeding-docs branch September 28, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anitacaron anitacaron anitacaron approved these changes

Assignees

@anitacaron anitacaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matentzn @anitacaron