Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block quote styles #1687

Merged
merged 4 commits into from
Apr 24, 2019
Merged

Block quote styles #1687

merged 4 commits into from
Apr 24, 2019

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Apr 24, 2019

Changes

  • Matches the default styles for Gutenberg's Pull Quote Quote block with Largo's styles for <blockquote>. Adds styles for <cite> elements.
  • Ensures that the CSS classes used by Largo's Classic Editor plugin "Module Wrapper" can be used on pull quotes. If you'd like to make use of these classes by adding them to a Pull Quote block in the "Additional CSS Class" control of the "Advanced" section of the pull quote's block settings, the list of classes is as follows:
    • type-pull-quote: appears larger in the story, with a slightly fancier presentation
    • type-aside: appears smaller, without decoration
    • alignleft: block is aligned left. This class may make it impossible to select the block in the editor with your mouse, requiring use of the keyboard to move the cursor into the block.
    • alignright: block is aligned right. This class may make it impossible to select the block in the editor with your mouse, requiring use of the keyboard to move the cursor into the block.
    • aligncenter: block is aligned center.
    • half: Block is half the width of the column at all but the smallest screen widths.

For #1682, but does not close it. We'll want to register block style variations for the Quote block eventually.

@benlk benlk added type: bug category: styles affects lots of styles, requiring visual testing labels Apr 24, 2019
@benlk benlk added this to the 0.6.2 milestone Apr 24, 2019
@benlk benlk merged commit 71aa739 into 0.5-dev Apr 24, 2019
@benlk benlk deleted the 1682-block-quote-styles branch April 30, 2019 21:18
@benlk
Copy link
Collaborator Author

benlk commented Apr 30, 2019

Correction: This did not update the styles for Gutenberg's Pull Quote Block. This updated the styles for Gutenberg's Quote Block, which are separate things. The discrepancy will be remedied in #1699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: styles affects lots of styles, requiring visual testing type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant