Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Article updates #36

Merged
merged 4 commits into from
Feb 18, 2020
Merged

Article updates #36

merged 4 commits into from
Feb 18, 2020

Conversation

joshdarby
Copy link

Changes

This pull request makes the following changes:

Before:
screencapture-investigatemidwest-org-2016-12-21-crisis-in-our-wells-iowas-private-well-water-often-goes-untested-presenting-unknown-health-risks-2020-02-18-10_03_53

After:
screencapture-mwcir-test-2016-12-21-crisis-in-our-wells-iowas-private-well-water-often-goes-untested-presenting-unknown-health-risks-2020-02-18-10_04_07

Why

For #28

Testing/Questions

Features that this PR affects:

  • Article page styling

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?

Steps to test this PR:

  1. View an article with a big hero image
  2. Make sure the size is reduced and matches the size on MTFP

@joshdarby joshdarby added this to the MCIR-003 - Site Updates milestone Feb 18, 2020
@joshdarby joshdarby self-assigned this Feb 18, 2020
@benlk
Copy link
Collaborator

benlk commented Feb 18, 2020

This PR updates Largo to 0.6.4; we can't do that for the reasons in #32 (comment).

But aside from that, this PR looks good. Setting the max-width to 1000px works.

benlk
benlk requested changes Feb 18, 2020
View reviewed changes
Copy link
Collaborator

@benlk benlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the Largo change; Largo should remain at commit 14b794dae07daff28d6bb2a92a2fac5ecf983415 until we decide what to do for #32

@joshdarby
Copy link
Author

Please revert the Largo change; Largo should remain at commit 14b794dae07daff28d6bb2a92a2fac5ecf983415 until we decide what to do for #32

@benlk Done in 69fc3f0

@joshdarby joshdarby merged commit 4d4f5af into master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlk benlk benlk approved these changes

@MirandaEcho MirandaEcho Awaiting requested review from MirandaEcho

Assignees

@joshdarby joshdarby

Labels
None yet
Projects
None yet
Milestone
MCIR-003 - Site Updates
Development

Successfully merging this pull request may close these issues.
2 participants
@joshdarby @benlk