CtTypeImpl: isSameParameter may fail in noclasspath mode

[msteinbeck]

isSameParameter contains the following lines:

...
} else if (expectedType instanceof CtTypeParameterReference) {
	if (!ctParameterType.isSubtypeOf(factory.Type().createReference(expectedType.getActualClass()))) {
		return false;
	}
} else if (ctParameterType instanceof CtTypeParameterReference) {
	CtTypeParameter declaration = (CtTypeParameter) ctParameterType.getDeclaration();
	if (declaration.getSuperclass() instanceof CtIntersectionTypeReference) {
...		

In no classpath mode, the first else if branch fails if expectedType is not in classpath and the second else if branch fails if ctParameterType is not in classpath.

So far as I can tell, the first else if branch should use getQualifiedName():

...createReference(expectedType.getQualifiedName())

and the second branch should check if declaration is null:

CtTypeParameter declaration = (CtTypeParameter) ctParameterType.getDeclaration();
if (declaration != null && declaration.getSuperclass() instanceof CtIntersectionTypeReference)

What do you think?

[surli]

Closed by #1767