review: feature Parameter remove refactoring

[pvojtechovsky]

Implements a "method parameter remove refactoring function". It expects a CtParameter as input - it is the parameter, which has to be removed by this refactoring.

The refactoring function:

in preparation phase:

• searches for all executables (methods and lambdas), which overrides/are overridden by the executable whose parameter has to be removed
• searches for all invocations to all found executables

in validation phase:

• reports an issue (stops refactoring) if to be removed parameter from any found executable is used
• reports an issue (stops refactoring) if to be removed argument from any found invocation is not a readonly literal (is not safe to remove it).

in refactoring phase

• removes appropriate argument from all found invocations
• removes appropriate parameter from all found executables

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170521.070955-114

New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT

Detected changes: 2.

Change 1

Name	Element
Old	method void spoon.support.visitor.SubInheritanceHierarchyResolver::forEachSubTypeInPackage(spoon.reflect.visitor.chain.CtConsumer)
New	method <T extends spoon.reflect.declaration.CtType<?>> void spoon.support.visitor.SubInheritanceHierarchyResolver::forEachSubTypeInPackage(spoon.reflect.visitor.chain.CtConsumer)
Code	java.generics.formalTypeParameterChanged
Description	The formal type parameter changed from 'T extends spoon.reflect.declaration.CtTypeInformation' to 'T extends spoon.reflect.declaration.CtType<?>'.
Breaking	source: breaking,

Change 2

Name	Element
Old	parameter void spoon.support.visitor.SubInheritanceHierarchyResolver::forEachSubTypeInPackage(===spoon.reflect.visitor.chain.CtConsumer===)
New	parameter <T extends spoon.reflect.declaration.CtType<?>> void spoon.support.visitor.SubInheritanceHierarchyResolver::forEachSubTypeInPackage(===spoon.reflect.visitor.chain.CtConsumer===)
Code	java.method.parameterTypeParameterChanged
Description	The type parameter of method parameter changed. The original type was 'spoon.reflect.visitor.chain.CtConsumer'while the new type is 'spoon.reflect.visitor.chain.CtConsumer<T extends spoon.reflect.declaration.CtType<?>>'.
Breaking	source: potentially_breaking,

[monperrus]

already done at previous line

[monperrus]

stateful :-( do you really need this?

[pvojtechovsky]

I need it because I do not know how to do it better...
Have a look at testCtParameterRemoveRefactoring

	@Test
	public void testCtParameterRemoveRefactoring() {
		String testPackagePath = "spoon/test/refactoring/parameter/testclasses";
		Factory factory = ModelUtils.build(new File("./src/test/java/"+testPackagePath));
		Launcher launcher = ModelUtils.getLastLauncher();
		
		CtType<?> typeA = factory.Class().get(TypeA.class);
...
//I need launcher to print model to java. Is there nicer way?
		launcher.setSourceOutputDirectory(new File("./target/spooned/"));
		launcher.getModelBuilder().generateProcessedSourceFiles(OutputType.CLASSES);
		ModelUtils.canBeBuilt("./target/spooned/"+testPackagePath, 8);

[monperrus]

Simply use a launcher directly

       @Test
	public void testCtParameterRemoveRefactoring() {
                Laucher spoon = new Launcher();
		spoon.addInputRessource("spoon/test/refactoring/parameter/testclasses");
		CtType<?> typeA = spoon.getFactory().factory.Class().get(TypeA.class);
...
//I need launcher to print model to java. Is there nicer way?
		launcher.setSourceOutputDirectory(new File("./target/spooned/"));
		launcher.getModelBuilder().generateProcessedSourceFiles(OutputType.CLASSES);
		ModelUtils.canBeBuilt("./target/spooned/"+testPackagePath, 8);

[pvojtechovsky]

The tests was modified to be compatible with not modified ModelUtils. The change in ModelUtils was rolled back.

[monperrus]

remove commented code?