doc: Bump version number after release 6.0.0 #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
changed the title
monperrus
reviewed
Nov 17, 2017
README.md
Outdated
| @@ -90,7 +90,7 @@ Snapshot version: | |||
| <dependency> | |||
| <groupId>fr.inria.gforge.spoon</groupId> | |||
| <artifactId>spoon-core</artifactId> | |||
| <version>6.0.0-SNAPSHOT</version> | |||
| <version>7.0.0-SNAPSHOT</version> | |||
There was a problem hiding this comment.
I hesitated but as CtImport is almost ready, it will be immediately a new major release of Spoon... So IMHO we won't have another minor release before Spoon 7.0.0.
monperrus
reviewed
Nov 17, 2017
doc/_config.yml
Outdated
| spoon_snapshot: "6.0.0-SNAPSHOT" | ||
| sidebar_version: version 6.0.0 | ||
| spoon_release: "6.0.0" | ||
| spoon_snapshot: "7.0.0-SNAPSHOT" |
monperrus
reviewed
Nov 17, 2017
doc/doc_homepage.md
Outdated
| @@ -35,6 +35,7 @@ You have different options: | |||
| Star Spoon on Github: [https://github.com/INRIA/spoon](https://github.com/INRIA/spoon). :-) | |||
|
|
|||
| <!-- .* Marker comment. --> | |||
| - November 17, 2017: Spoon 6.0.0 is released! Check the [(changelog)](https://github.com/INRIA/spoon/releases/tag/spoon-core-6.0.0) as this major release may introduce breaking changes :warning: | |||
There was a problem hiding this comment.
I would say "as this major release may introduce breaking changes
I'd say "there are few non backward-compatible changes, see changes"
|
Imports are breaking but not part of the main public API.I'd propose first aim at 6.1 and we see
something really big breaking we could change to 7.0.
…On 11/17/17 4:31 PM, Simon Urli wrote:
***@***.**** commented on this pull request.
----------------------------------------------------------------------------------------------------
In README.md <#1732 (comment)>:
> @@ -90,7 +90,7 @@ Snapshot version:
<dependency>
<groupId>fr.inria.gforge.spoon</groupId>
<artifactId>spoon-core</artifactId>
- <version>6.0.0-SNAPSHOT</version>
+ <version>7.0.0-SNAPSHOT</version>
I hesitated but as CtImport is almost ready, it will be immediately a new major release of
Spoon... So IMHO we won't have another minor release before Spoon 7.0.0.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1732 (comment)>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxDUj8Hf4RIGlw8jKdiT5E68wY9OA_3ks5s3abigaJpZM4QiLWV>.
|
They are part of the main public API through |
|
Yes, I know, but this is not the kind of methods that are typically used by clients.
In default mode, you never manipulate the imports. In auto-import mode, you don't manipulate them as
well, Spoon does it for you.
…On 11/20/17 10:08 AM, Simon Urli wrote:
Imports are breaking but not part of the main public API.
They are part of the main public API through |CompilationUnit#getImports()| which is used by clients.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1732 (comment)>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxDUlYAawcXsmkS51QvaombraG7LMtPks5s4UGTgaJpZM4QiLWV>.
|
Yes, but you can get them as in #1629. Then if we change the return type, we break their code. I'm ok to bump the version to 6.1.0 if we do a release before merging CtImport, else I really don't see the point to not follow the semantic versioning. |
|
@monperrus when you merge this PR take care to delete the Spoon 7.0.0 snapshot from gforge.inria.fr. |
|
Detected changes by Revapi: 215. Old API: fr.inria.gforge.spoon:spoon-core:jar:6.0.0 New API: fr.inria.gforge.spoon:spoon-core:jar:6.1.0-SNAPSHOT
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.