Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review chore: Travis: Skip checkstyle when calling mvn install for installing dependencies #1746

Merged
merged 1 commit into from
Nov 25, 2017

Conversation

surli
Copy link
Collaborator

@surli surli commented Nov 24, 2017

@surli surli changed the title chore: Travis: Skip checkstyle when calling mvn install for installing dependencies review chore: Travis: Skip checkstyle when calling mvn install for installing dependencies Nov 24, 2017
@monperrus
Copy link
Collaborator

it seems to me that this switch should be in travis-jdk9.sh and travis-jdk8.sh instead

@surli
Copy link
Collaborator Author

surli commented Nov 24, 2017

it seems to me that this switch should be in travis-jdk9.sh and travis-jdk8.sh instead

No, it needs to be everywhere: by default Travis calls mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V before executing the script to install the dependencies.
In our case, it makes all fails when there's a checkstyle error, instead of only checkstyle script.

After the change, every job will execute the installation of dependencies with skipping checkstyle, and only then calls its own script like checkstyle checking for the checkstyle script or testing for the jdk8/9 scripts.

@monperrus
Copy link
Collaborator

OK, then that's OK for me.

@monperrus monperrus merged commit 22ec309 into INRIA:master Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants