Adds comment support #554
Merged
Adds comment support #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Buggy copied/pasted comment in CtVisitor.java |
tdurieux
force-pushed
the
feat_comments
branch
9 times, most recently
from
599d240
to
fb893b6
Compare
|
looks promising! |
tdurieux
force-pushed
the
feat_comments
branch
6 times, most recently
from
9987eff
to
5ad4ce4
Compare
| @@ -297,6 +297,16 @@ void report(Processor<?> processor, Level level, | |||
| void setGenerateJavadoc(boolean generateJavadoc); | |||
|
|
|||
| /** | |||
| * Returns the value of the option generate-comments. | |||
| */ | |||
| boolean isGenerateComments(); | |||
tdurieux
force-pushed
the
feat_comments
branch
3 times, most recently
from
781a534
to
462c8d4
Compare
| * This code element defines a comment | ||
| * | ||
| */ | ||
| public interface CtComment extends CtElement, CtStatement { |
There was a problem hiding this comment.
only extends CtStatement
|
add Javadoc DocComment in List (and remove the original String field in CtElement) |
|
reuse same option as javadoc (and change doc of this doc option) |
|
Done |
| * Get the type of the comment | ||
| * @return the comment type | ||
| */ | ||
| CommentType getType(); |
There was a problem hiding this comment.
getCommentType (in order not to confuse with getType of CtTypedElem
tdurieux
force-pushed
the
feat_comments
branch
3 times, most recently
from
8d6551f
to
16c1593
Compare
| */ | ||
| public interface CtComment extends CtStatement { | ||
| enum CommentType { | ||
| FILE_COMMENT, // comment at the top of a file |
There was a problem hiding this comment.
FILE before the package line (typically the license)
|
doc of comment type enum, depreciation, documentation of contract for java doc |
| @@ -1,5 +1,7 @@ | |||
| language: java | |||
|
|
|||
| sudo: true | |||
There was a problem hiding this comment.
Can you change to sudo: required ? https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments
|
Done |
| @@ -743,6 +744,11 @@ public void visitCtCircularTypeReference(CtCircularTypeReference reference) { | |||
| } | |||
|
|
|||
| @Override | |||
| public void visitCtComment(CtComment comment) { | |||
| throw new RuntimeException("Unknow Element"); | |||
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.