feat(shadow): Build shadow element from class object. #569

GerardPaligot · 2016-03-30T14:58:23Z

No description provided.

monperrus · 2016-03-30T15:14:00Z

src/test/java/spoon/test/factory/AnnotationFactoryTest.java

-		Assert.assertEquals(2,annot.names().length);
-		Assert.assertEquals("foo",annot.names()[0]);
-		Assert.assertEquals("bar",annot.names()[1]);
+		final CtAnnotation<SampleAnnotation> annotation = type.getAnnotation(type.getFactory().Annotation().createReference(SampleAnnotation.class));


do this change the return type of getAnnotation? is it backward compatible?

There are two methods named getAnnotation(...):

getAnnotation(Class<Annotation>) which returns an Annotation.

getAnnotation(CtTypeReference) which returns an CtAnnotation<Annotation>.

monperrus · 2016-03-30T15:16:47Z

looks nice!

we have to find a good name for JScanner and add some API documentation.

also, we should add some documentation about this.

seintur · 2016-04-16T06:31:15Z

src/main/java/spoon/reflect/reference/CtExecutableReference.java

+	 * Returns a subtype {@link CtExecutable} that corresponds to the reference
+	 * even if its declaring type isn't in the Spoon source path.
+	 *
+	 * @return the executable declaration correspond to the reference.


Typo: correspond -> that corresponds

GerardPaligot · 2016-04-19T12:43:30Z

src/main/java/spoon/reflect/declaration/CtElement.java

+	 *
+	 * @return true if the element is a shadow element, otherwise false.
+	 */
+	boolean isShadow();


Move to CtShadowable

monperrus · 2016-04-19T14:18:07Z

new feature: add documentation page

GerardPaligot · 2016-04-19T14:42:37Z

For me:

Spoon analyzes source code. However, this source code may refer to libraries (as a field, parameter, or method return type). Those library may be or not in the classpath. The boundary between source and libraries is handled by the reference mechanism.

When you're consider a reference object (say, a TypeReference), there are three cases:

Case 1: the reference points to a code element for which the source code is present. In this case, reference.getDeclaration() returns this code element (e.g. TypeReference.getDeclaration returns the CtType representing the given java file). reference.getTypeDeclaration() is identical to reference.getDeclaration().

Case 2: the reference points to a code element for which the source code is NOT present, but for which the binary class is in the classpath (either the JVM classpath or the --source-classpath argument). In this case, reference.getDeclaration() returns null and reference.getTypeDeclaration returns a partial CtType built using runtime reflection. Those objects built using runtime reflection are called shadow objects; and you can identify them with method isShadow. (This also holds for getFieldDeclaration and getExecutableDeclaration)

Case 3: : the reference points to a code element for which the source code is NOT present, but for which the binary class is NOT in the classpath. This is called in Spoon the noclasspath mode. In this case, both reference.getDeclaration() and reference.getTypeDeclaration() return null. (This also holds for getFieldDeclaration and getExecutableDeclaration)

monperrus · 2016-04-22T11:58:13Z

src/test/java/spoon/test/main/MainTest.java

+		new CtScanner() {
+			@Override
+			public void scan(CtElement element) {
+				if (element != null && element.getClass().isAssignableFrom(CtShadowable.class)) {


should it be
CtShadowable.class.isAssignableFrom(element.getClass())
?

Good point.

monperrus reviewed Mar 30, 2016
View reviewed changes

GerardPaligot changed the title ~~feat(shadow): Build shadow element from class object.~~ WIP feat(shadow): Build shadow element from class object. Apr 7, 2016

seintur reviewed Apr 16, 2016
View reviewed changes

GerardPaligot changed the title ~~WIP feat(shadow): Build shadow element from class object.~~ feat(shadow): Build shadow element from class object. Apr 19, 2016

GerardPaligot reviewed Apr 19, 2016
View reviewed changes

GerardPaligot added 7 commits April 22, 2016 13:23

feat(shadow): Build shadow element from class object.

4e8dd19

refactor(shadow): Create CtShadowable.

2355a8d

docs: Updates documentation.

7f3cf8a

refactor(context): Rename all context classes.

f1a2e65

refactor: Removes useless test case.

f93a063

test: Adds a new assert in RefactoringTest

7f02f26

docs: Adds documentation of the feature

d81e1cb

monperrus reviewed Apr 22, 2016
View reviewed changes

fix(test): Flip isAssignableFrom in MainTest.

f2d0ca3

monperrus merged commit b2518c1 into INRIA:master Apr 22, 2016

GerardPaligot deleted the feat_shadow branch April 22, 2016 12:24

This was referenced Apr 22, 2016

EnumFactory.getEnum(Class<?>) returns null #563

Closed

feature: add support for runtime reflection of binary classes #566

Closed

tdurieux mentioned this pull request Jun 24, 2016

Release Spoon 5.2.0 #725

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(shadow): Build shadow element from class object. #569

feat(shadow): Build shadow element from class object. #569

GerardPaligot commented Mar 30, 2016

monperrus Mar 30, 2016

GerardPaligot Mar 30, 2016

monperrus commented Mar 30, 2016

seintur Apr 16, 2016

GerardPaligot Apr 19, 2016

monperrus commented Apr 19, 2016

GerardPaligot commented Apr 19, 2016

monperrus Apr 22, 2016

GerardPaligot Apr 22, 2016

feat(shadow): Build shadow element from class object. #569

feat(shadow): Build shadow element from class object. #569

Conversation

GerardPaligot commented Mar 30, 2016

monperrus Mar 30, 2016

Choose a reason for hiding this comment

GerardPaligot Mar 30, 2016

Choose a reason for hiding this comment

monperrus commented Mar 30, 2016

seintur Apr 16, 2016

Choose a reason for hiding this comment

GerardPaligot Apr 19, 2016

Choose a reason for hiding this comment

monperrus commented Apr 19, 2016

GerardPaligot commented Apr 19, 2016

monperrus Apr 22, 2016

Choose a reason for hiding this comment

GerardPaligot Apr 22, 2016

Choose a reason for hiding this comment