Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: doc: add SUPPLY-CHAIN.md #6063

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ludvigch
Copy link
Contributor

This PR adds documentation of the changes in #6016 as well as a short description on how to verify the attestations created during a release. I am a bit unsure if the manual verification process is relevant or if it suffices with the simpler method of using GitHub CLI to verify an attestation?

Addressing @monperrus suggestion

Copy link
Contributor

@algomaster99 algomaster99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some suggestions.

image

Do you know what this hash is for on rekor?

SUPPLY-CHAIN.md Outdated
Get the sigstore/rekor attestation:
[https://search.sigstore.dev/?hash=804c2ab449cc16052b467edc3ab1f7cf931f8e679685c0e16fab2fcc16ecfb41](https://search.sigstore.dev/?hash=804c2ab449cc16052b467edc3ab1f7cf931f8e679685c0e16fab2fcc16ecfb41)

Manually verifying using openssl: Sigstore docs provide a [tutorial](https://docs.sigstore.dev/logging/verify-release/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unclear where do I get .pem and .sig file for spoon artifact in order to verify using openssl. Could you list the steps for that here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried replicating this part of the tutorial for some spoon artifacts, but the data structure differs from their examples.. I am unsure if this is because the tutorial is outdated or because of the attest-build-provenance action's usage of signatures.

On further thought, I think that the entry in sigstore/rekor might be a signature of the actual attestation rather than the artifact, that would also explain why the hashes differ as you mention in the previous comment.

My suggestion is that I remove the manual part and only provide examples of how to verify attestations using GitHub CLI, adding how to do it with a locally dowloaded attestation from the spoon repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On further thought, I think that the entry in sigstore/rekor might be a signature of the actual attestation rather than the artifact

entry is just the UUID so it simply a unique random number so it cannot be a signature.

I remove the manual part and only provide examples of how to verify attestations using GitHub CLI,

I am okay with it. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the guide! :)

SUPPLY-CHAIN.md Outdated Show resolved Hide resolved
Copy link
Contributor

@algomaster99 algomaster99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@algomaster99
Copy link
Contributor

@I-Al-Istannen @monperrus ready for merge from my side

@ludvigch ludvigch changed the title WIP doc: add SUPPLY-CHAIN.md review: doc: add SUPPLY-CHAIN.md Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants