Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ability to reserve DOIs through DataCite #5093

Closed
scolapasta opened this issue Sep 25, 2018 · 9 comments · Fixed by #6901
Closed

Implement ability to reserve DOIs through DataCite #5093

scolapasta opened this issue Sep 25, 2018 · 9 comments · Fixed by #6901

Comments

@scolapasta
Copy link
Contributor

Datacite has added the ability to reserve DOIs pre publish (as EZID did). This ticket will track adding the ability to reserve those DOIs when we create datasets, as well as a one time ability to reserve DOIs for existing drafts that have only reserved their DOIs on the dataverse side.

@poikilotherm
Copy link
Contributor

This could be a better approach than using multiple providers as we had planned first in #4833 and #5082. Private drafts seem to be a proper fit for our use case, even so they won't be resolvable until "registered". (Scientist could share a Dataverse installation URL instead for collaboration...)

Do you guys think this is a good topic for a community contribution?

@poikilotherm
Copy link
Contributor

(That was a quick and comprehensive answer, @pdurbin 😉 )

@pdurbin
Copy link
Member

pdurbin commented Oct 10, 2018

@poikilotherm heh. Thanks for chatting at http://irclog.iq.harvard.edu/dataverse/2018-10-10

As I mentioned there @sekmiller and I talked about it and we don't think the refactoring he's working on for #5060 will conflict.

We are, of course, available to answer any questions.

Thanks for linking to https://support.datacite.org/docs/doi-states which explains the new feature, listing three states:

  • Draft DOIs
  • Registered DOIs
  • Findable DOIs

We're pretty sure that we'd want DOIs to go straight from "draft" to "findable" so that they're indexed in DataCite Search.

@poikilotherm
Copy link
Contributor

To be more complete, I should mention that these states are not usable via the XML based MDS API, but via the REST API and EZID API.

This could be a big blocker, because that means changing the whole code of DOIDataCiteServiceBean currently using the MDS API.

As it seems that @sekmiller wrote huge parts of the class: any ideas how to tackle this?

@pdurbin
Copy link
Member

pdurbin commented Oct 10, 2018

@poikilotherm as promised, I mentioned this issue at standup. Thanks for linking to https://support.datacite.org/docs/doi-states#section-doi-states-outside-of-fabrica which gives details on your assertion that we can't use the old DataCite API for this:

screen shot 2018-10-10 at 12 00 18 pm

The vibe I got from @scolapasta and @sekmiller is that we certainly wouldn't mind if you poke around with the new DataCite API and report back any interesting findings!

@pdurbin
Copy link
Member

pdurbin commented Jan 4, 2019

@poikilotherm hi! Are you actively working on this? Do you still want to be assigned to it?

@poikilotherm
Copy link
Contributor

No I am currently concentrating on "getting things testable".
I don't mind being assigned, as this is definitly a feature we need for FZJ and will be done once we have a prod setup done.

@poikilotherm
Copy link
Contributor

Status update: we still will need this down the road, but concentrate on getting things moving to production currently.

@djbrooke
Copy link
Contributor

djbrooke commented Apr 29, 2020

pdurbin added a commit that referenced this issue May 29, 2020
The fix required removing the throwing of RuntimeException in
DataCiteRESTfullClient. This is considered a system exception and rolls
back the entire "create dataset" command and transaction.

This commit also remove the temporary fix I had put in to allow datasets
to be created when DataCite is down: 9cbd5d3

Basically, it's a better fix. We need the create time to be null if
DataCite is down so that we can query for unreserved DOIs and then
reserve them.
pdurbin added a commit that referenced this issue May 29, 2020
@pdurbin pdurbin removed their assignment May 29, 2020
pdurbin added a commit that referenced this issue Jun 1, 2020
Conflicts:
src/main/java/propertyFiles/Bundle.properties
pdurbin added a commit that referenced this issue Jun 3, 2020
pdurbin added a commit that referenced this issue Jun 4, 2020
kcondon added a commit that referenced this issue Jun 4, 2020
ability to reserve DOIs through DataCite #5093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants