Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Production date" hard coded in JSON metadata export #6426

Closed
jggautier opened this issue Dec 2, 2019 · 5 comments · Fixed by #6478
Closed

"Production date" hard coded in JSON metadata export #6426

jggautier opened this issue Dec 2, 2019 · 5 comments · Fixed by #6478
Assignees

Comments

@jggautier
Copy link
Contributor

jggautier commented Dec 2, 2019

In recent versions of Dataverse, including the latest 4.18.1, the"JSON" metadata export of every dataset includes productionDate: "Production Date".

Screen Shot 2019-12-02 at 1 32 54 PM

It seems to be hard coded, appears only in the "JSON" export, and doesn't seem to affect how the "Production Date" metadata (that depositors fill out) is recorded (see typeName: productionDate at the bottom of the screenshot).

But it could confuse people who are trying to make sense of the metadata in the JSON export and I think should be removed. Then I think each installation will need to re-publish each published dataset's JSON metadata export.

@pdurbin
Copy link
Member

pdurbin commented Dec 2, 2019

@djbrooke
Copy link
Contributor

djbrooke commented Dec 9, 2019

@jggautier Thanks. So a quick fix (hopefully :)) and a note about running reexports in the release notes.

@djbrooke
Copy link
Contributor

@jggautier @scolapasta - can you discuss before we pick this up for the sprint? Thank you!

@jggautier
Copy link
Contributor Author

The to-do in the code that @pdurbin pointed to says "get "Production Date" from datasetfieldvalue table":

Screen Shot 2019-12-11 at 3 52 27 PM

I didn't realize that when the dataset also has a user-entered Distribution Date, the JSON export also includes the distributionDate at the "datasetVersion" level:

Screen Shot 2019-12-11 at 4 47 46 PM

So it seems like the intent was to repeat, in the JSON export, the date metadata that users enter in the Distribution Date and Production Date fields (in the Citation metadata block). (But right now the Production Date is hard coded, and that to-do is saying that it should be dynamic, like the Production Date is.)

But why is the dataset version's Distribution Date and Production Date metadata, already in the JSON export at the "metadataBlocks" level, repeated at the "datasetVersion" level above it? Is it because it's easier to get the values at that level? Why not include the Deposit Date?

@sekmiller sekmiller self-assigned this Dec 20, 2019
@djbrooke djbrooke self-assigned this Dec 20, 2019
@djbrooke
Copy link
Contributor

Adding myself to add a release note for re-running exports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants