Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The set param in the OAI-PMH request URL is wrongfully encoded twice #7009

Closed
JingMa87 opened this issue Jun 23, 2020 · 0 comments · Fixed by #7010
Closed

The set param in the OAI-PMH request URL is wrongfully encoded twice #7009

JingMa87 opened this issue Jun 23, 2020 · 0 comments · Fixed by #7010

Comments

@JingMa87
Copy link
Contributor

JingMa87 commented Jun 23, 2020 •
edited
Loading

When the issue occurs: when harvesting a client which has set names with special characters like a colon (:)
Which page it occurs on: Root>Dashboard>Manage Harvesting Clients (returns 0 results without error message)
To whom it occurs: people who harvest
Version: 4.20
Technicalities: in the source code the set name is encoded first in the OAIHandler class on line 70 and then again in the Parameters class on line 85.
@JingMa87 JingMa87 mentioned this issue Jun 23, 2020
Merged
kcondon added a commit that referenced this issue Jul 2, 2020
@kcondon
Merge pull request #7010 from JingMa87/7009-double-set-name-encoding
bd736d2 
#7009 Removed one of the redundant encoding functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#7009 Removed one of the redundant encoding functions.
1 participant
@JingMa87